Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): updating the shopping cart icon #115

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix(icon): updating the shopping cart icon #115

merged 1 commit into from
Nov 10, 2022

Conversation

heyabinanto
Copy link
Contributor

@heyabinanto heyabinanto commented Nov 10, 2022

updating the shopping cart icon

Pull Request

Description

Describe your changes (or add ticket description) and add relevant screenshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

updating the shopping cart icon
@heyabinanto heyabinanto merged commit 72f6424 into main Nov 10, 2022
@heyabinanto heyabinanto deleted the fix/icon branch November 10, 2022 13:41
supcar pushed a commit that referenced this pull request Nov 10, 2022
## [3.1.2](v3.1.1...v3.1.2) (2022-11-10)

### Bug Fixes

* **icon:** updating the shopping cart icon ([#115](#115)) ([72f6424](72f6424))
@supcar
Copy link
Collaborator

supcar commented Nov 10, 2022

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3437286451

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.088%

Totals Coverage Status
Change from base Build 3436941651: 0.0%
Covered Lines: 869
Relevant Lines: 872

💛 - Coveralls

@github-actions
Copy link

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/bin/git' failed with exit code 1
St.
Category Percentage Covered / Total
🟢 Statements 99.48% 951/956
🟢 Branches 90.23% 157/174
🟢 Functions 98.18% 54/55
🟢 Lines 99.66% 869/872

Test suite run success

238 tests passing in 34 suites.

Report generated by 🧪jest coverage report action from c57f211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants