Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix problem with npm start on Windows 10 OS [#HEYUI-184] #102

Conversation

nsacerdote-heycar
Copy link
Contributor

@nsacerdote-heycar nsacerdote-heycar commented Oct 25, 2022

Fix HEYUI-184

Pull Request

Description

Use path.join instead of forward slash on .storybook/main.js, line 15.

Also remove not used code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How do I test this

  • Using Windows 10
  • Clone the repository
  • Run npm install
  • Run npm start
  • Storybook starts! 🎉

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 99.79% 957/959
🟢 Branches 92.9% 157/169
🟢 Functions 100% 51/51
🟢 Lines 100% 877/877

Test suite run success

238 tests passing in 34 suites.

Report generated by 🧪jest coverage report action from 15fb34c

@nsacerdote-heycar nsacerdote-heycar merged commit 42c8ae3 into main Oct 25, 2022
@nsacerdote-heycar nsacerdote-heycar deleted the fix/HEYUI-184-fix-storybook-configuration-on-windows-10 branch October 25, 2022 12:24
derek-heycar pushed a commit that referenced this pull request Oct 25, 2022
## [2.9.1](v2.9.0...v2.9.1) (2022-10-25)

### Bug Fixes

* **storybook configuration:** use path.join instead of forward slash ([#102](#102)) ([42c8ae3](42c8ae3))
@derek-heycar
Copy link
Contributor

🎉 This PR is included in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants