Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate sanitized names with prefix #1321

Open
mrlubos opened this issue Nov 21, 2024 · 0 comments
Open

Investigate sanitized names with prefix #1321

mrlubos opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
internal ⚙️ Internal development related
Milestone

Comments

@mrlubos
Copy link
Member

mrlubos commented Nov 21, 2024

By default, we will sanitize illegal names so the output doesn't throw. For example, a schema with the name "400" gets generated as const _400 = 400. I noticed that using "name builders" unnecessarily preserves the sanitized name. For example, the pattern z{{name}} would generate const z_400 = 400. This is no longer needed since the original name would've been legal, i.e. const z400 = 400. Need to investigate how widespread this issue is before deciding how to address it.

@mrlubos mrlubos added the internal ⚙️ Internal development related label Nov 21, 2024
@mrlubos mrlubos added this to the Parser milestone Nov 21, 2024
@mrlubos mrlubos self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal ⚙️ Internal development related
Projects
None yet
Development

No branches or pull requests

1 participant