From 487c702a476b739b58bebaae5f30ca9faf2041e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Wed, 6 Dec 2017 22:51:49 +0800 Subject: [PATCH 1/2] Revert "hotfix(file): cast dev to uint32" This reverts commit a2184229232a9893179b43475f344c556ec4d956. Since https://github.com/nodejs/node/pull/16705 is merged, the hotfix is unecessary. --- test/scripts/box/file.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/scripts/box/file.js b/test/scripts/box/file.js index 6bd04809c0..f7f2a283df 100644 --- a/test/scripts/box/file.js +++ b/test/scripts/box/file.js @@ -73,8 +73,6 @@ describe('File', () => { file.stat((err, fileStats) => { if (err) return callback(err); - //todo: cast dev to uint32 until https://github.com/nodejs/node/issues/16496 is resolved - fileStats.dev = (new Uint32Array([fileStats.dev]))[0]; fileStats.should.eql(fs.statSync(file.source)); callback(); }); From 0ea508b64f83b0ddc7be60a8d4eace9156a06c28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Sun, 10 Dec 2017 09:33:14 +0800 Subject: [PATCH 2/2] test(appveyor): update to exact node.js version --- appveyor.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index b76c65128a..960f39703d 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -5,15 +5,15 @@ init: # Test against these versions of Node.js. environment: matrix: - - nodejs_version: "6" - - nodejs_version: "8" + - nodejs_version: "6.12.2" + - nodejs_version: "8.9.3" matrix: fast_finish: true # Install scripts. (runs after repo cloning) install: - - ps: Install-Product node $env:nodejs_version + - ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) - npm install -g npm - npm install