post_link should throw error if no slug/post found

[GazEdge]

I have had a few errors creep into my posts because the post_link plugin returns null if no slug or post is found. The result of this is a very hard to find missing link and text in the generated post. It may be better instead to throw an error, or at least return an anchor with an error href e.g.

'use strict';

/**
 * Post link tag
 *
 * Syntax:
 *   {% post_link slug [title] %}
 */
module.exports = function(ctx) {
  var Post = ctx.model('Post');

  return function postLinkTag(args) {
    var slug = args.shift();
    var title = args.length ? args.join(' ') : post.title;
    var error =  '<a href="#error-' + args[0] + '" title="' + title + '">' + title + '</a>';

    if (!slug) return error;

    var post = Post.findOne({slug: slug});
    if (!post) return error;

    return '<a href="' + ctx.config.root + post.path + '" title="' + title + '">' + title + '</a>';
  };
};

[leesei]

Tracked in #1771

[leesei]

The proposed solution is not yet implemented.
#1771 only handles rendering of errors.

[stevenjoezhang]

Pull Request: #4426

hexo/lib/plugins/tag/post_link.js

Line 27 in c0bf222

if (!post) return;