fix: rename trace_id variable to correlation_id
#408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
changed the title
correlation_id variable
jooola
changed the title
correlation_id variabletrace_id variable to correlation_id
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 64 64
Lines 2879 2879
=======================================
Hits 2676 2676
Misses 203 203 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Jul 3, 2024
jooola
pushed a commit
that referenced
this pull request
Jul 3, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.1](v2.0.0...v2.0.1) (2024-07-03) ### Bug Fixes * `assignee_type` is required when creating a primary ip ([#409](#409)) ([bce5e94](bce5e94)) * clean unused arguments in the `Client.servers.rebuild` method ([#407](#407)) ([6d33c3c](6d33c3c)) * details are optional in API errors ([#411](#411)) ([f1c6594](f1c6594)) * rename `trace_id` variable to `correlation_id` ([#408](#408)) ([66a0f54](66a0f54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I learned that we should not use the trace_id name for a correlation_id.
I scoped this change as a fix, as the correltation_id is only used internally.