Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add include_deprecated option when fetching images by name #375

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Apr 2, 2024

Allow to get a deprecated image by name.

@jooola jooola changed the title feat: add include_deprecated option when fetching images by name feat: add include_deprecated option when fetching images by name Apr 2, 2024
@jooola jooola requested a review from apricote April 2, 2024 12:40
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (2e9c5fc) to head (4593014).
Report is 1 commits behind head on main.

❗ Current head 4593014 differs from pull request most recent head dc2c2a5. Consider uploading reports for the commit dc2c2a5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          65       65           
  Lines        2881     2881           
=======================================
  Hits         2675     2675           
  Misses        206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hcloud/images/client.py Show resolved Hide resolved
@jooola jooola merged commit 6d86f86 into hetznercloud:main Apr 2, 2024
10 checks passed
@jooola jooola deleted the include_deprecated branch April 2, 2024 14:30
jooola pushed a commit that referenced this pull request Apr 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.35.0](v1.34.0...v1.35.0)
(2024-04-02)


### Features

* add `include_deprecated` option when fetching images by name
([#375](#375))
([6d86f86](6d86f86))


### Bug Fixes

* raise warnings for the `ImagesClient.get_by_name` deprecation
([#376](#376))
([b24de80](b24de80))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants