feat: allow auto-completing context flag #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
==========================================
- Coverage 61.49% 61.48% -0.01%
==========================================
Files 238 238
Lines 8522 8538 +16
==========================================
+ Hits 5241 5250 +9
- Misses 2572 2576 +4
- Partials 709 712 +3 ☔ View full report in Codecov by Sentry. |
apricote
reviewed
Sep 6, 2024
| ) | ||
|
|
||
| OptionContext = newOpt( | ||
| "context", | ||
| "Currently active context", | ||
| "", | ||
| OptionFlagConfig|OptionFlagEnv|OptionFlagPFlag, | ||
| func(_ hcapi2.Client, cfg Config, _ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { | ||
| ctxs := cfg.Contexts() |
There was a problem hiding this comment.
🤡 Does this consider the --config flag?
apricote
approved these changes
Sep 12, 2024
phm07
pushed a commit
that referenced
this pull request
Oct 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.48.0](v1.47.0...v1.48.0) (2024-10-25) ### Features * allow auto-completing context flag ([#861](#861)) ([7495b14](7495b14)) * **primary-ip:** allow setting auto-delete on create ([#860](#860)) ([b6aecb3](b6aecb3)), closes [#855](#855) ### Bug Fixes * **image:** only use numerical IDs for label auto-completion ([#865](#865)) ([1d10d92](1d10d92)) * **primary-ip:** labels ignored in create command ([#885](#885)) ([7a17174](7a17174)), closes [#883](#883) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #853 for more information. Closes #853