fix: printing for server create with mulitple networks #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 59.58% 59.71% +0.12%
==========================================
Files 209 209
Lines 7693 7692 -1
==========================================
+ Hits 4584 4593 +9
+ Misses 2458 2451 -7
+ Partials 651 648 -3 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Jul 25, 2024
apricote
added a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.46.0](v1.45.0...v1.46.0) (2024-07-25) ### Features * **load-balancer-type:** show traffic details for each location in describe output ([5c9380c](5c9380c)) * **server-type:** show traffic details for each location in describe output ([5c9380c](5c9380c)) ### Bug Fixes * ineffective poll interval option ([#822](#822)) ([41aaa56](41aaa56)) * printing for server create with mulitple networks ([#824](#824)) ([f3fcbd2](f3fcbd2)) * **server-type:** remove deprecated traffic column ([5c9380c](5c9380c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Julian Tölle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #820
Also add some more data in the mocked server calls to cover more code.