Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): allow JSON & YAML output in reset-password #716

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Mar 19, 2024

This PR adds the ability to output the root password after a password reset in JSON or YAML format.

Closes #715

@phm07 phm07 added the feature label Mar 19, 2024
@phm07 phm07 self-assigned this Mar 19, 2024
@phm07 phm07 requested a review from a team as a code owner March 19, 2024 10:03
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 58.73%. Comparing base (23ec75b) to head (975b1a8).

❗ Current head 975b1a8 differs from pull request most recent head adf90bb. Consider uploading reports for the commit adf90bb to get more accurate results

Files Patch % Lines
internal/cmd/server/reset_password.go 36.36% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   58.77%   58.73%   -0.04%     
==========================================
  Files         179      179              
  Lines        6539     6546       +7     
==========================================
+ Hits         3843     3845       +2     
- Misses       2088     2093       +5     
  Partials      608      608              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I can confirm that it works with jq :)

@phm07 phm07 force-pushed the reset-password-output-options branch from 975b1a8 to adf90bb Compare April 2, 2024 10:27
@phm07 phm07 merged commit 373287b into main Apr 2, 2024
4 checks passed
@phm07 phm07 deleted the reset-password-output-options branch April 2, 2024 10:30
phm07 pushed a commit that referenced this pull request Apr 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.43.0](v1.42.0...v1.43.0)
(2024-04-03)


### Features

* allow deletion of multiple resources at once
([#719](#719))
([3b896fe](3b896fe))
* improve missing argument error messages
([#711](#711))
([e7f9e74](e7f9e74))
* **server:** allow JSON & YAML output in reset-password
([#716](#716))
([373287b](373287b)),
closes [#715](#715)


### Bug Fixes

* removing last rule from firewall fails with invalid_input error
([#696](#696))
([acab17c](acab17c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please enable yaml output for server reset-password
2 participants