Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(primary-ip): updating the name resets auto-delete #604

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Nov 7, 2023

Due to not correctly checking if the auto-delete flag was set, every time the update command was called and the auto-delete flag wasn't set, auto deletion was erroneously disabled.

Due to not correctly checking if the auto-delete flag was set, every time the update command was called and the auto-delete flag wasn't set, auto deletion was erroneously disabled.
@phm07 phm07 added the bug label Nov 7, 2023
@phm07 phm07 self-assigned this Nov 7, 2023
@phm07 phm07 requested a review from a team as a code owner November 7, 2023 11:57
@phm07 phm07 merged commit 292f6c4 into main Nov 7, 2023
3 checks passed
@phm07 phm07 deleted the fix-primary-ip-update branch November 7, 2023 11:58
phm07 added a commit that referenced this pull request Nov 7, 2023
Due to not correctly checking if the auto-delete flag was set, every
time the update command was called and the auto-delete flag wasn't set,
auto deletion was erroneously disabled.
phm07 pushed a commit that referenced this pull request Nov 14, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.40.0](v1.39.0...v1.40.0)
(2023-11-14)


### Features

* add warning messages to context commands
([#605](#605))
([d84fe36](d84fe36)),
closes [#588](#588)
* allow JSON output on resource creation
([#609](#609))
([d7241fe](d7241fe)),
closes [#470](#470)
* **context:** ask to use HCLOUD_TOKEN when creating new context
([#582](#582))
([54e582a](54e582a)),
closes [#576](#576)
* pretty-print JSON output
([#610](#610))
([ca4706f](ca4706f))
* print out IPs after they were created
([#590](#590))
([0e0eaa8](0e0eaa8))


### Bug Fixes

* "create" actions were not awaited in some cases
([#589](#589))
([1c0e50a](1c0e50a))
* **image:** backup is suggested as type in update command
([#603](#603))
([6ea4695](6ea4695))
* inconsistent formatting in "describe" commands
([#593](#593))
([b70dfe3](b70dfe3))
* **network:** create prints success to stderr instead of stdout
([#587](#587))
([0a4c361](0a4c361))
* **primary-ip:** list does now allow to output IP column
([#594](#594))
([ee8e6ed](ee8e6ed)),
closes [#591](#591)
* **primary-ip:** updating the name resets auto-delete
([#604](#604))
([292f6c4](292f6c4))
* static resource list commands only return first 50 entries
([#592](#592))
([7e511d9](7e511d9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants