Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that pghstore._native.dump works as expected #9

Open
sigmavirus24 opened this issue Apr 8, 2020 · 0 comments
Open

Validate that pghstore._native.dump works as expected #9

sigmavirus24 opened this issue Apr 8, 2020 · 0 comments

Comments

@sigmavirus24
Copy link

I believe we test this, but we also have a dump function defined insrc/pghstore/__init__.py with an incompatible signature for the case when _speedups is in play. Both need to have matching signatures and we need to test that both work as expected in either case with those additional parameters.

Warning This may require delving into _speedups.c to introduce similar behaviour to a dump function there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant