Centralize arg handling, writing to stderr and process exit in libcnb_runtime
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b_runtime` This change takes a "Functional Core - Imperitive Shell" type of approach by centralizing argument handling, writing of error messages to stderr and calls to `process::exit` in the main `libcnb_runtime` function. This allows for other functions such as `libcnb_runtime_detect` and `libcnb_runtime_build` to be re-used in other runtimes. Note: This commit has been extracted out from https://github.com/Malax/libcnb.rs/pull/313 (which will be superseded by this an other PRs).
This was referenced Mar 2, 2022
Malax
approved these changes
Mar 7, 2022
Malax
referenced
this pull request
Mar 7, 2022
Note: This commit is made on top of https://github.com/Malax/libcnb.rs/pull/369 Note: This commit has been extracted out from https://github.com/Malax/libcnb.rs/pull/313 (which will be superseded by this and other PRs).
Malax
referenced
this pull request
Mar 7, 2022
* Make `libcnb_runtime_build` etc public Note: This commit is made on top of https://github.com/Malax/libcnb.rs/pull/369 Note: This commit has been extracted out from https://github.com/Malax/libcnb.rs/pull/313 (which will be superseded by this and other PRs). * Hide newly exposed runtime types from docs They're only exposed for advanced use-cases and should not be used by buildpack authors directly. * Update CHANGELOG * Expose all public runtime types Co-authored-by: Nokome Bentley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change takes a "Functional Core - Imperative Shell" type of approach by centralizing argument handling, writing of error messages to stderr and calls to
process::exitin the mainlibcnb_runtimefunction.This allows for other functions such as
libcnb_runtime_detectandlibcnb_runtime_buildto be re-used in other runtimes.Note: This commit has been extracted out from https://github.com/Malax/libcnb.rs/pull/313 (which will be superseded by this an other PRs).