Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group minor/patch version Rust Dependabot updates into one PR #679

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Oct 9, 2023

Previously only libcnb related dependency updates were grouped into one Dependabot PR.

Now there is a second group, that takes advantage of Dependabot's new semver version level grouping feature:
https://github.blog/changelog/2023-08-17-grouped-version-updates-by-semantic-version-level-for-dependabot/

In addition, the check changelog skipping strategy has been updated to use the explicit skip changelog label for (a) explicitness, (b) to allow removing the label in situations where we realise a changelog entry is required (eg libcnb buildpack API version bumps), (c) for consistency with other repos.

Lastly, the redundant bundler entry in the Dependabot config has been removed (a leftover from #674).

GUS-W-14258249.

Previously only libcnb related dependency updates were grouped into
one Dependabot PR.

Now there is a second group, that takes advantage of Dependabot's new
semver version level grouping feature:
https://github.blog/changelog/2023-08-17-grouped-version-updates-by-semantic-version-level-for-dependabot/

In addition, the check changelog skipping strategy has been updated to
use the explicit `skip changelog` label for (a) explicitness, (b) to
allow removing the label in situations where we realise a changelog
entry is required (eg libcnb buildpack API version bumps), (c) for
consistency with other repos.

Lastly, the redundant `bundler` entry in the Dependabot config has
been removed (a leftover from #674).

GUS-W-14258249.
@edmorley edmorley self-assigned this Oct 9, 2023
@edmorley edmorley marked this pull request as ready for review October 9, 2023 12:49
@edmorley edmorley requested a review from a team as a code owner October 9, 2023 12:49
@edmorley edmorley merged commit 9825ca7 into main Oct 9, 2023
18 checks passed
@edmorley edmorley deleted the edmorley/dependabot-groups branch October 9, 2023 13:04
colincasey added a commit that referenced this pull request Oct 11, 2023
* main:
  Update Inventory for heroku/nodejs-engine (#681)
  Update Inventory for heroku/nodejs-npm-engine (#678)
  Bump the rust-dependencies group with 2 updates (#680)
  Group minor/patch version Rust Dependabot updates into one PR (#679)

# Conflicts:
#	Cargo.lock
colincasey added a commit that referenced this pull request Oct 11, 2023
* main:
  Update Inventory for heroku/nodejs-engine (#681)
  Update Inventory for heroku/nodejs-npm-engine (#678)
  Bump the rust-dependencies group with 2 updates (#680)
  Group minor/patch version Rust Dependabot updates into one PR (#679)

# Conflicts:
#	Cargo.lock
#	buildpacks/nodejs-npm-engine/CHANGELOG.md
colincasey added a commit that referenced this pull request Oct 18, 2023
* main:
  Added `nodejs-npm-install` Buildpack (#625)
  Added `nodejs-npm-engine` Buildpack (#623)
  Prepare release v1.1.7 (#683)
  Update Inventory for heroku/nodejs-engine (#682)
  Update Inventory for heroku/nodejs-engine (#681)
  Update Inventory for heroku/nodejs-npm-engine (#678)
  Bump the rust-dependencies group with 2 updates (#680)
  Group minor/patch version Rust Dependabot updates into one PR (#679)
  Add `npm` to `nodejs-engine` build plan (#622)

# Conflicts:
#	buildpacks/nodejs-engine/tests/fixtures/node-with-indexjs/package-lock.json
#	buildpacks/nodejs-engine/tests/fixtures/node-with-serverjs/package-lock.json
#	buildpacks/nodejs-engine/tests/integration_test.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants