Add a way to cancel a timer #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
added a commit
that referenced
this pull request
Oct 10, 2024
I already had to write it for the Ruby buildpack (https://github.com/heroku/buildpacks-ruby/blob/c8cdfd0be3a61f7b50d36cae12ec3d22f8068afc/buildpacks/ruby/src/layers/shared.rs#L146), it's useful to have here, and it's useful to show the result of an output in tests like #10.
schneems
added a commit
that referenced
this pull request
Oct 10, 2024
I already had to write it for the Ruby buildpack (https://github.com/heroku/buildpacks-ruby/blob/c8cdfd0be3a61f7b50d36cae12ec3d22f8068afc/buildpacks/ruby/src/layers/shared.rs#L146), it's useful to have here, and it's useful to show the result of an output in tests like #10.
When dealing with network IO it's expected that we will need to retry. There's currently no good way to advertise what's happening to a user. This new public API allows for canceling of running timers (without emitting "Done") after which time the timer can be restarted. That allows for an output that could look like this: ``` - JVM version 8.0.0 - Downloading JVM .... (retrying in 1 second) - Retrying ....... (retrying in 2 seconds) - Retrying ...... (Done 4s) ```
schneems
force-pushed
the
schneems/interrupt-api
branch
from
938a342 to
5f28e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with network IO it's expected that we will need to retry. There's currently no good way to advertise what's happening to a user.
This new public API allows for canceling of running timers (without emitting "Done") after which time the timer can be restarted. That allows for an output that could look like this: