Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output conflicts with std::process::Output #4

Closed
schneems opened this issue Jun 4, 2024 · 0 comments · Fixed by #5
Closed

Output conflicts with std::process::Output #4

schneems opened this issue Jun 4, 2024 · 0 comments · Fixed by #5

Comments

@schneems
Copy link
Collaborator

schneems commented Jun 4, 2024

In libcnb I used BuildpackOutput because that's what it literally was. When I generalized the name, I introduced a conflict:

  • Output conflicts with std::process::Output

One of the expectations is that people will use this in conjunction with std::process::Command a bunch, therefore conflicting with std::prcesss::Output isn't great out of the gate.

Alternatives:

  • Stream conflicts with some other std structs
  • Log is the wrong mental model (because people think logs are not seen by people)
  • Cli isn't the right frame as people expect that to be interactive
  • Tui is not a commonly known term and the people who do know it would also expect it to be interactive https://github.com/ratatui-org/ratatui
  • Out feels TOO general
  • Text no known conflicts.Text<SubBullet> isn't horrible. It is what it is, except that it's text printed to the user, not written to retrieve later
  • Print no known conflicts. Print<SubBullet> is also not horrible. I think it's closer than Text.
  • Something else?
schneems added a commit that referenced this issue Jun 6, 2024
When trying to use both `std::process::Output` and `bullet_stream::Output` in the same file there is an import collision.

With this change the `Print`  struct is introduced. The `Output` struct is still available but is deprecated.

Close #4
schneems added a commit that referenced this issue Jun 6, 2024
When trying to use both `std::process::Output` and `bullet_stream::Output` in the same file there is an import collision.

With this change the `Print`  struct is introduced. The `Output` struct is still available but is deprecated.

Close #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant