syscall to set the seed of the random number generator #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stlankes
commented
Sep 11, 2020
stlankes
commented
- using the core library to create a random number
- removing inline assembly
jbreitbart
reviewed
Sep 11, 2020
| unsafe { | ||
| llvm_asm!("rdrand $0" : "=r"(value) ::: "volatile"); | ||
| unsafe { | ||
| if SUPPORTS_RDRAND { |
There was a problem hiding this comment.
Is there a log message in case we have fall back to pseudo random values?
There was a problem hiding this comment.
I added a debug message in src/syscalls/random.rs
There was a problem hiding this comment.
Are these printed every time a random number is generated? Can we print an info message at startup saying we are using either the hardware random generator or park miller lehmer software random generator?
jbreitbart
requested changes
Sep 12, 2020
src/syscalls/random.rs
Outdated
| value | ||
| } else { | ||
| debug!("Fallback to a software-based random number generator"); |
There was a problem hiding this comment.
You have missed this one 😄
- this function isn't cryptographicly secure - use sys_sys_secure_rand32/sys_secure_rand64 to cryptographicly secure random number
simonschoening
pushed a commit
to simonschoening/libhermit-rs
that referenced
this pull request
Aug 26, 2021
…os#98) * add syscall to set the seed of the pseudo random number generator * use function to create cryptographicly secure random numbers * remove obsolete GitHub Action workflow "build" * add comments to explain the functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.