Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling fails with segfault #94

Closed
jschwe opened this issue Aug 30, 2020 · 4 comments
Closed

Compiling fails with segfault #94

jschwe opened this issue Aug 30, 2020 · 4 comments

Comments

@jschwe
Copy link
Contributor

jschwe commented Aug 30, 2020

Compiling libhermit-rs currently fails with a segmentation fault. This behaviour was introduced with the nightly-2020-08-24. This is likely to be related to the following issue: rust-lang/rust#75922.
The comments there suggest that we will have to make changes on our end to the #[naked] functions.
@stlankes
Copy link
Contributor

Yes! Hm, I also create an issue rust-lang/rust#76061. I will look into rust-lang/rust#75922.

@tlambertz
Copy link
Contributor

I had a similar issue with naked functions recently (though this were runtime issues), where naked functions with parameters behaved weirdly. rust-lang/rust#75417 fixed some of that, but people are unsure if naked+parameters should be supported or not. My workaround was using global_asm! and declaring the symbol as a extern 'C' fn.

@stlankes
Copy link
Contributor

Yes, seems to be the better solution

@stlankes stlankes mentioned this issue Aug 30, 2020
Merged
@stlankes
Copy link
Contributor

I close this issue. PR #95 solved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stlankes @jschwe @tlambertz