Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the rusty-hermit name clash #35

Closed
jounathaen opened this issue Apr 28, 2020 · 6 comments · Fixed by #860
Closed

Resolve the rusty-hermit name clash #35

jounathaen opened this issue Apr 28, 2020 · 6 comments · Fixed by #860

Comments

@jounathaen
Copy link
Member

Current Situation:

The naming of the repositories and the crates is contradictory.

Crate Name Repository Name Task
rusty-hermit https://github.com/hermitcore/libhermit-rs The Kernel itself
hermit-sys https://github.com/hermitcore/rusty-hermit FFI - What is actually imported in the applications. libhermit-rs is downloaded and linked in the magic build.rs script

Problems

Solution Attempts

These are the two solutions I came up with

Rename the Repository Attempt

Rename this Crate Attempt

  • change the name of this crate to libhermit-rs
  • update the crate name in hermit-sys/hermit-loader/...
@jounathaen
Copy link
Member Author

jounathaen commented May 5, 2020

Another Solution Attempt:

Merge Everything Attempt

  • Put libhermit-rs into the rusty-hermit repository (not as a submodule)
  • Leave a link to rusty-hermit at this repository

@stlankes
Copy link
Contributor

stlankes commented Jun 3, 2020

Do we solve the issue? I think that #77 describes the remaining problem.

@jounathaen
Copy link
Member Author

Ah, the remaining problem I almost forgot about is, that the crate names are still mixed up

@mkroening
Copy link
Member

@jounathaen, do you feel like the "Rename this Crate Attempt" has been successful in #505 so that this issue can be closed?

@jounathaen
Copy link
Member Author

Yes, this is resolved now! 🥳

@mkroening
Copy link
Member

There are still places left where we link to libhermit-rs using the name RustyHermit, like in the loader Readme. We should have another word on this, and perhaps adopt the name Hermit (without Rusty) in more places, where we are not specific to Rust userspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants