From db6d9c2b3c8af9d39e711b40a2c94525dde44191 Mon Sep 17 00:00:00 2001 From: Herko Lategan Date: Wed, 27 Nov 2024 09:41:43 +0000 Subject: [PATCH] roachprod: remove cdrb_test for nightly Previously, we included the `--crdb_test` build flag for `roachprod`. This binary is only built to be used as part of the `roachprod update` logic. Adding the flag causes roachprod to produce a log of metamorphic vars which is not expected behaviour when using it as a CLI tool. Informs: #124592 Epic: None Release note: None --- .../cockroach/nightlies/roachtest_compile_component.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/build/teamcity/cockroach/nightlies/roachtest_compile_component.sh b/build/teamcity/cockroach/nightlies/roachtest_compile_component.sh index 3efe131b7ab2..78555e77baec 100755 --- a/build/teamcity/cockroach/nightlies/roachtest_compile_component.sh +++ b/build/teamcity/cockroach/nightlies/roachtest_compile_component.sh @@ -99,8 +99,12 @@ case "$component" in artifacts=("pkg/cmd/roachtest/roachtest_/roachtest:bin/roachtest.$os-$arch") ;; roachprod) - # Roachprod binary. - bazel_args=(//pkg/cmd/roachprod --crdb_test) + # Roachprod binary. This binary is only built here to support the logic + # behind `roachprod update`. Hence, we do not need to add `--crdb_test` to + # the build command as we do for `roachtest`. Adding the build flag causes + # the binary to log metamorphic vars on each command invocation, which is + # not ideal from a user experience perspective. + bazel_args=(//pkg/cmd/roachprod) artifacts=("pkg/cmd/roachprod/roachprod_/roachprod:bin/roachprod.$os-$arch") ;; *)