From ab7a048ac32f52134ed4584725574e9f508f77c1 Mon Sep 17 00:00:00 2001 From: Yahor Yuzefovich Date: Thu, 30 May 2024 10:27:38 -0700 Subject: [PATCH] util/mon: disable recently added assertion for now There are some more issues to address (probably around the server shutdown), so let's disable the recently added assertion that all short-living monitors are stopped when the parent is stopped. Release note: None --- pkg/util/mon/bytes_usage.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/pkg/util/mon/bytes_usage.go b/pkg/util/mon/bytes_usage.go index 52632e676dd5..f85fef2788b0 100644 --- a/pkg/util/mon/bytes_usage.go +++ b/pkg/util/mon/bytes_usage.go @@ -653,12 +653,13 @@ func (mm *BytesMonitor) doStop(ctx context.Context, check bool) { // Ignore mm itself if it is short-living. numShortLiving-- } - if numShortLiving > 0 { - panic(errors.AssertionFailedf( - "found %d short-living non-stopped monitors in %s\n%s", - numShortLiving, mm.name, sb.String(), - )) - } + // TODO(#124848): uncomment this. + //if numShortLiving > 0 { + // panic(errors.AssertionFailedf( + // "found %d short-living non-stopped monitors in %s\n%s", + // numShortLiving, mm.name, sb.String(), + // )) + //} } }