Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix: Prevent Override of Existing innerCustomChildren #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent Override of Existing innerCustomChildren #80

wants to merge 1 commit into from

Conversation

luzmcosta
Copy link

Because the existingChildren check references customChildren
but the render uses the customInnerChildren property, this plugin
resets customInnerChildren, overriding previous children, thereby
preventing other extensions from rendering. Fixing the check to
inspect customInnerChildren allows this extension to co-exist with
other extensions leveraging the customInnerChildren property.

@luzmcosta
Fix override of other innerCustomChildren.
6b7e98e 
Because the check references `customChildren`but the insert is against
`customInnerChildren`, this plugin overrides elements inserted by other
plugins via `customInnerChildren`. These edits fix that by updating the
`existingChildren` check to inspect the correct array of elements.
j-f1 added a commit to j-f1/forked-hyper-statusline that referenced this pull request Sep 3, 2018
@j-f1
Merge pull request henrikruscon#80 into develop
1ec1537
@j-f1
Copy link

j-f1 commented Sep 3, 2018

I’ve published this to @j-f/hyper-statusline. You can swap hyper-statusline with @j-f/hyper-statusline in your config to switch. Feel free to contribute!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luzmcosta @j-f1