Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngOnChanges missing input argument #9

Open
ekuusi opened this issue Mar 14, 2017 · 1 comment
Open

ngOnChanges missing input argument #9

ekuusi opened this issue Mar 14, 2017 · 1 comment

Comments

@ekuusi
Copy link

ekuusi commented Mar 14, 2017

To make the module AoT compliant, ngOnChanges needs to have an optional input argument.

angular2-nvd3.directive and angular2-nvd3.component are missing that argument. Their methods should be:

    ngOnChanges(changes?) {
        this.ngNvD3.updateWithOptions(this.options, this.data);
    }
@michielvermeir
Copy link
Contributor

Hey, well spotted. I didn't run into this issue before (don't know why exactly), so I missed this one making the config-related changes for AOT. Guess I'll have to make another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants