Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not export single-indexer wind/unwind/index functions #341

Open
1 task done
max-sanchez opened this issue Dec 11, 2024 · 0 comments
Open
1 task done

Do not export single-indexer wind/unwind/index functions #341

max-sanchez opened this issue Dec 11, 2024 · 0 comments
Assignees
@marcopeereboom
Labels
status: triage This is awaiting review. Maintainers should this label once triaged type: bug This is a bug

Comments

@max-sanchez
Copy link
Contributor

Confirmation

  • I have checked for similar issues.

Describe the bug

The functions UtxoIndexerUnwind, UtxoIndexerWind, UtxoIndexer, TxIndexerUnwind, TxIndexerWind, TxIndexer cannot effectively be called externally due to s.indexing check w/ panic, since external caller cannot set s.indexing, and upstream use of TBC with "manual" indexing now uses SyncIndexersToHash and does not need direct access to the individual indexers.

Expected behaviour

The functions UtxoIndexerUnwind, UtxoIndexerWind, UtxoIndexer, TxIndexerUnwind, TxIndexerWind, TxIndexer should not be exported.

Environment

Additional Information

No response
@max-sanchez max-sanchez added status: triage This is awaiting review. Maintainers should this label once triaged type: bug This is a bug labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcopeereboom marcopeereboom

Labels
status: triage This is awaiting review. Maintainers should this label once triaged type: bug This is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@max-sanchez @marcopeereboom