Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrain from PoP mining of old keystone blocks #210

Open
1 task done
Leonardiae opened this issue Aug 17, 2024 · 0 comments
Open
1 task done

Refrain from PoP mining of old keystone blocks #210

Leonardiae opened this issue Aug 17, 2024 · 0 comments
Labels
area: popm This is a change to popm (PoP Miner) type: bug This is a bug type: enhancement This improves existing functionality

Comments

@Leonardiae
Copy link
Contributor

Confirmation

  • I have checked for similar issues.

Describe the bug

Since mining older blocks increases the risk of spending fees while being too late to be eligable for a reward I think the PoP miner should refrain from mining older keystone blocks.

Also because you risk to mine those blocks again in case you restart the PoP miner and already mined the earlier keystone blocks in previous session.

Expected behaviour

Check the current block and what latest keystone block is, set that as the last known keystone and don't mine that anymore.

Environment

Version:
Operating System:
Architecture:

Additional Information

I started a PoP miner while latest block was 1315551.
When block 1315575 is being detected, the PoP miner starts mining block 1315575, 1315550 and 1315525. I think it should only mine 1315575 and not 1315550 and 1315525 anymore.

@Leonardiae Leonardiae added status: triage This is awaiting review. Maintainers should this label once triaged type: bug This is a bug labels Aug 17, 2024
@joshuasing joshuasing added area: popm This is a change to popm (PoP Miner) type: enhancement This improves existing functionality and removed status: triage This is awaiting review. Maintainers should this label once triaged labels Aug 18, 2024
@joshuasing joshuasing changed the title Refrein from PoP mining of old keystone blocks Refrain from PoP mining of old keystone blocks Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: popm This is a change to popm (PoP Miner) type: bug This is a bug type: enhancement This improves existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants