Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crane version to latest #268

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Update crane version to latest #268

merged 3 commits into from
Sep 25, 2024

Conversation

ulucs
Copy link
Contributor

@ulucs ulucs commented Sep 24, 2024

Hello! In newer crane versions, crane.lib.${system} has been removed; so I'm creating this PR to:

  • Replace the crane.lib.${system} usage with the equivalent (crane.mkLib pkgs)
  • Update the crane version

tomkarw
tomkarw approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@tomkarw tomkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

CI is failing due to some unrelated check failing, I'll update Cargo dependencies and it will make this pipeline green.

flake.nix Show resolved Hide resolved
@ulucs ulucs merged commit 0cf7c49 into main Sep 25, 2024
7 checks passed
@ulucs ulucs deleted the ulucs/update-crane branch September 25, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mara-schulke mara-schulke mara-schulke approved these changes

@tomkarw tomkarw tomkarw approved these changes

@poliorcetics poliorcetics Awaiting requested review from poliorcetics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulucs @tomkarw @mara-schulke