Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust tests to nix checks #244

Merged
4 commits merged into from May 14, 2024
Merged

Add rust tests to nix checks #244

4 commits merged into from May 14, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2024

Rust tests weren't current running as part of nix checks. This PR adds nextest to our nix checks run.

I ignored two of the integration tests which require CA root certificates to be setup because they'll need extra changes and I wanted to keep the PRs small. Another PR will follow

@ghost ghost self-assigned this May 9, 2024
@ghost
Copy link
Author

ghost commented May 9, 2024

The Clippy failure seems unrelated to my changes in this PR.
It looks like a positive catch that was previously undetected but is now detected with a new version of clippy

@ghost
Copy link
Author

ghost commented May 9, 2024

The Clippy failure seems unrelated to my changes in this PR. It looks like a positive catch that was previously undetected but is now detected with a new version of clippy

Created a fix in #245
Will rebase if that gets merged first

nix/buffrs.nix Outdated Show resolved Hide resolved
@ghost ghost requested a review from mara-schulke May 10, 2024 10:33
@ghost ghost merged commit 4ca7cac into helsing-ai:main May 14, 2024
7 checks passed
@ghost ghost deleted the dmw/add-tests-to-nix-checks branch May 14, 2024 12:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant