Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nix devx + verify it in CI #219

Merged
36 commits merged into from Feb 9, 2024
Merged

Improve nix devx + verify it in CI #219

36 commits merged into from Feb 9, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2024

The following changes were made:

  • add 2 new CI jobs which run under a new Nix Buffers CI workflow (we also cache the nix store locally)
    -- nix flake check on ubuntu
    -- nix flake check on mac
  • enable all CI workflows to be manually triggered from the actions panel
  • clean up flake.nix
  • speed up nix builds by providing libgit and openssl, instead of building from source

nix flake check now does the following:

  • ensure all nix files are correctly formatted
  • verify we can build buffrs under nix

@ghost ghost requested a review from mara-schulke February 6, 2024 16:14
.envrc Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@mara-schulke mara-schulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the comment RE gitignore, this lgtm!

flake.nix Outdated Show resolved Hide resolved
.nix/buffrs.nix Outdated Show resolved Hide resolved
.nix/buffrs.nix Outdated Show resolved Hide resolved
.nix/libgit2.nix Outdated Show resolved Hide resolved
.nix/libgit2.nix Outdated Show resolved Hide resolved
.nix/toolchain.nix Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
@ghost ghost merged commit b5eecd8 into helsing-ai:main Feb 9, 2024
7 checks passed
@ghost ghost deleted the eg/nix-on-develop branch February 9, 2024 11:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants