-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor vendor dir #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdbrkfxrpt
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few very minor nits aside, this lgtm
wngr
approved these changes
Aug 17, 2023
Co-authored-by: Oliver Wangler <[email protected]>
Co-authored-by: Oliver Wangler <[email protected]>
Co-authored-by: Florian Eich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pr refactors the package store from:
To
And simplifies code generation implementation.
Upsides
This drastically simplifies the package store layout, and more importantly, enables people to compile it using any protobuf code gen tool, such as protoc without any change.
Furthermore it removes the type duplication problem that occured when nesting dependencies:
Before the change, you had two version of the
c
library types:Which is now resolved, since tonic generates this structure:
Downsides
This change has the implication that all dependencies may only use one single version of
c
which is not ideal. We can and will solve this by introducing proper version resolution mechanism soon.