test: define event sourcing events in proto #874
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSchaefer
changed the title
MaxSchaefer
force-pushed
the
proto-events
branch
from
97fb9d7 to
2d4a0c2
Compare
FoseFx
reviewed
Oct 29, 2024
libs/hwes/event.go
Outdated
| } | ||
|
|
||
| func MessageToEventName(protoMessage proto.Message) string { | ||
| protoEventType := proto.GetExtension(protoMessage.ProtoReflect().Descriptor().Options(), pbEventsV1.E_EventType).(string) |
There was a problem hiding this comment.
what if I want to work with a v2, v3 etc event?
FoseFx
reviewed
Oct 29, 2024
| a.RegisterEventListener(propertyEventsV1.PropertyFieldTypeDataSelectOptionsRemoved, a.onFieldTypeDataSelectOptionsRemoved) | ||
| a.RegisterEventListener(propertyEventsV1.PropertyArchived, a.onPropertyArchived) | ||
| a.RegisterEventListener(propertyEventsV1.PropertyRetrieved, a.onPropertyRetrieved) | ||
| a.RegisterEventListener(hwes.MessageToEventName(&pbTechnicalEventsV1.PropertyCreatedEvent{}), a.onPropertyCreated) |
There was a problem hiding this comment.
we could move this into RegisterEventListener and get rid of a lot of code duplication + get better type guarantees
The go_package "property-svc" gets converted into "property_svc" for the generated Golang code. If we can to import this proto, the generated Golang code imports "property-svc". This inconsistency results in non-compiling Golang code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues does this pull request close?
closes #873