Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAttachedPropertyValues not returning empty always_include property values #840

Open
MaxSchaefer opened this issue Sep 25, 2024 · 4 comments · May be fixed by #875
Open

GetAttachedPropertyValues not returning empty always_include property values #840

MaxSchaefer opened this issue Sep 25, 2024 · 4 comments · May be fixed by #875
Assignees
Labels
bug Something isn't working invalid This doesn't seem right priority: high High priority issue

Comments

@MaxSchaefer
Copy link
Member

MaxSchaefer commented Sep 25, 2024

Describe the bug

If a property has the always_include flag but it empty, the property does not get returned by GetAttachedPropertyValues. Thats incorrect. Property values of properties should be shown if they are not empty or in the always_include list.

Describe how to produce the bug

  • Create a property
  • Dont create a property value
  • Set this property to the property view always_include list of an arbitrary patient or task
  • Call GetAttachedPropertyValues for this arbitrary patient or task
  • Your property is not there
  • Attach a property value
  • Your property is there

Additional context

cc. @DasProffi

No response

@MaxSchaefer MaxSchaefer added bug Something isn't working priority: high High priority issue labels Sep 25, 2024
@MaxSchaefer MaxSchaefer removed their assignment Oct 9, 2024
@FoseFx FoseFx self-assigned this Oct 9, 2024
@FoseFx
Copy link
Member

FoseFx commented Oct 9, 2024

Can't reproduce:

16dac7b

Passes

@FoseFx
Copy link
Member

FoseFx commented Oct 9, 2024

@DasProffi

@FoseFx FoseFx added the invalid This doesn't seem right label Oct 10, 2024
@FoseFx
Copy link
Member

FoseFx commented Oct 14, 2024

I will retry with other Value types

@FoseFx FoseFx linked a pull request Oct 22, 2024 that will close this issue
@FoseFx
Copy link
Member

FoseFx commented Oct 22, 2024

I've added a matrix test, that tests all {Task, Patient} x {Number, Text, ...} combinations: #875

A different test is failing due to a side effect fixed in another PR of mine, but the new tests all pass.

From what I can see this is not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right priority: high High priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants