[stable/grafana] Allow secrets for sidecar (#13492)

[fr-ser]

Updated the sidecar image to version 0.0.18
This allows also using secrets for volume mounts
This way the dashboard and data source import can be extended to those
datatypes

Signed-off-by: Sergej Herbert [email protected]

What this PR does / why we need it:

I pushed a PR into a used sidecar image (https://github.com/kiwigrid/k8s-sidecar) now we can use secrets for data source and dashboard provisioning for grafana.

Which issue this PR fixes

• fixes [stable/grafana] datasource provisioning with sidecar should be done trough secrets #13492

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• [ x] DCO signed
• [ x] Chart Version bumped
• [ x] Variables are documented in the README.md
• [ x] Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

Hi @fr-ser. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maorfr]

hey @fr-ser,

thanks for this PR!
i like the idea of resourceType to define which resource type is to be used. very clever. but do we really have to support "both"?

i suggest to make this PR backwards compatible by having the default be configmap, and users can choose to use secrets if they specify it in their values.yaml.

wdyt?

at a later point we can add this change to other breaking changes and bump the major version of the chart.

[maorfr]

/assign
/ok-to-test

[fr-ser]

I would like to be backwards compatible, so I also prefer keeping configmap as default @maximbaz

But I would also like to keep the option both, as reading secrets (because of their base64 encoding or cluster permissions) is not as easy.
A cluster admin might want to keep datasources (because of the passwords that are included) as secrets but dashboards as configmaps..

[maximbaz]

A cluster admin might want to keep datasources (because of the passwords that are included) as secrets but dashboards as configmaps..

This makes a lot of sense, and this is how I am planning to use this personally. I don't expect "configmaps" to go away in the next major version, I only want to be able to switch to "secrets" as soon as I see that I am about to put my password in there.

And in this case, if we are going to support "both" anyway, I still think introducing a new configuration option to control this isn't very useful, as opposed to just supporting both resource types out of the box.

[fr-ser]

Did a rebase to stay compatible with the current master (don't know what the rebase, merge policy is here...)

The big change is (aside from the Readme) the default watching for configmaps and secrets.

[fr-ser]

So is there anything I can do to help get this feature merged?

I can rebase/merge from master again of course, but it will be outdated within a couple of days I suppose.

[maorfr]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fr-ser, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/grafana/OWNERS [maorfr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment