Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mongodb] loadBalancerSourceRanges can be specified for mongodb Helm chart #15324

Merged
merged 3 commits into from
Jul 9, 2019
Merged

[stable/mongodb] loadBalancerSourceRanges can be specified for mongodb Helm chart #15324

merged 3 commits into from
Jul 9, 2019

Conversation

peter-moffatt
Copy link
Contributor

What this PR does / why we need it:

Allows loadBalancerSourceRanges to be specified on the mongodb Service. This is required by anyone who wants to restrict the IP ranges which can access a deployed mongodb instance.

@tompizmor

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 8, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @peter-moffatt. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@peter-moffatt
Bump chart version
f7a3e65 
Signed-off-by: Peter Moffatt <[email protected]>
@peter-moffatt
Copy link
Contributor Author

/assign @sameersbn

juan131
juan131 reviewed Jul 9, 2019
View reviewed changes
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution @peter-moffatt
Could you please take a look to my suggestions? Thanks in advance.

stable/mongodb/templates/svc-primary-rs.yaml Outdated
@@ -22,6 +22,10 @@ spec:
{{- if .Values.service.externalIPs }}
externalIPs: {{ toYaml .Values.service.externalIPs | nindent 4 }}
{{- end }}
{{- if .Values.service.loadBalancerSourceRanges }}
loadBalancerSourceRanges:
{{- toYaml .Values.service.loadBalancerSourceRanges | nindent 4 }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're using nindent, you can use a single line:

+  loadBalancerSourceRanges: {{ toYaml .Values.service.loadBalancerSourceRanges | nindent 4 }}
-  loadBalancerSourceRanges:
-    {{- toYaml .Values.service.loadBalancerSourceRanges | nindent 4 }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast response. I've applied the change and confirmed it works as expected on my end.

stable/mongodb/templates/svc-standalone.yaml Outdated
@@ -22,6 +22,10 @@ spec:
{{- if .Values.service.externalIPs }}
externalIPs: {{ toYaml .Values.service.externalIPs | nindent 4 }}
{{- end }}
{{- if .Values.service.loadBalancerSourceRanges }}
loadBalancerSourceRanges:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change applied.

@peter-moffatt
Minor change to formatting
a935090 
Signed-off-by: Peter Moffatt <[email protected]>
juan131
juan131 approved these changes Jul 9, 2019
View reviewed changes
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the suggestions! Approving your changes

@juan131
Copy link
Collaborator

juan131 commented Jul 9, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2019
@juan131
Copy link
Collaborator

juan131 commented Jul 9, 2019

/lgtm
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan131, peter-moffatt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7619867 into helm:master Jul 9, 2019
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
@peter-moffatt
[stable/mongodb] loadBalancerSourceRanges can be specified for mongod…
d6199ef 
…b Helm chart (helm#15324)

* loadBalancerSourceRanges can be specified for mongodb Helm chart

Signed-off-by: Peter Moffatt <[email protected]>

* Bump chart version

Signed-off-by: Peter Moffatt <[email protected]>

* Minor change to formatting

Signed-off-by: Peter Moffatt <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juan131 juan131 juan131 approved these changes

@carrodher carrodher Awaiting requested review from carrodher

@tompizmor tompizmor Awaiting requested review from tompizmor

Assignees

@sameersbn sameersbn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peter-moffatt @k8s-ci-robot @juan131 @sameersbn @helm-bot