Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/pomerium] Chart updates for pomerium v0.1.0 #15320

Merged
merged 4 commits into from
Jul 8, 2019
Merged

[stable/pomerium] Chart updates for pomerium v0.1.0 #15320

merged 4 commits into from
Jul 8, 2019

Conversation

travisgroth
Copy link
Collaborator

@travisgroth travisgroth commented Jul 8, 2019

What this PR does / why we need it:

This bumps the app version to support the latest release of Pomerium, and expose new metrics functionality. Examples and documentation included.

/cc @desimone

Related Issues:

pomerium/pomerium#214

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@k8s-ci-robot k8s-ci-robot requested a review from desimone July 8, 2019 12:52
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@victornoel
Copy link
Collaborator

@travisgroth I see you haven't included all the latest changes that were merged in pomerium/pomerium-helm, is that on purpose? In particular there are some that are important I think about config checksums.

@travisgroth
Copy link
Collaborator Author

@victornoel Not intentional, no. I'll look at updating both of them to be consistent.

@desimone
Copy link
Collaborator

desimone commented Jul 8, 2019

/retest

travisgroth and others added 3 commits July 8, 2019 18:43
fix config checksum: based on file and only for pods
deployment: fix missing resources field

Signed-off-by: Travis Groth <[email protected]>
- Expose metrics port and update documentation

- Bump chart and app version for v0.1.0 release

Signed-off-by: Travis Groth <[email protected]>
Signed-off-by: Travis Groth <[email protected]>
@travisgroth
Copy link
Collaborator Author

/retest

Signed-off-by: Travis Groth <[email protected]>
@travisgroth
Copy link
Collaborator Author

/test pull-charts-e2e

@desimone
Copy link
Collaborator

desimone commented Jul 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desimone, travisgroth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 60f7936 into helm:master Jul 8, 2019
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
* [stable/pomerium] bugfixes

fix config checksum: based on file and only for pods
deployment: fix missing resources field

Signed-off-by: Travis Groth <[email protected]>

* [stable/pomerium] v0.1.0 release

- Expose metrics port and update documentation

- Bump chart and app version for v0.1.0 release

Signed-off-by: Travis Groth <[email protected]>

* Fix lint error

Signed-off-by: Travis Groth <[email protected]>

* Fix CI test policy

Signed-off-by: Travis Groth <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants