This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/suitecrm] adds chart to deploy SuiteCRM #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
unguiculus
suggested changes
Jun 24, 2017
There was a problem hiding this comment.
Please apply best practices for standard labels, especially the app label.
https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/labels.md
|
Marking as stale. Please update within the next week. |
|
Closing as stale. Feel free to re-open if/when you decide to work on this again. |
sameersbn
force-pushed
the
chart-suitecrm
branch
from
1c0644b to
095a022
Compare
|
sorry missed you comments. |
unguiculus
suggested changes
Jul 29, 2017
|
|
||
| {{/* | ||
| Create a default fully qualified app name. | ||
| We truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). |
|
|
||
| {{/* | ||
| Create a default fully qualified app name. | ||
| We truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). |
sameersbn
force-pushed
the
chart-suitecrm
branch
from
6540e19 to
b94449e
Compare
|
updated with the required changes. |
unguiculus
suggested changes
Jul 29, 2017
stable/suitecrm/templates/NOTES.txt
Outdated
|
|
||
| {{- if eq .Values.serviceType "ClusterIP" }} | ||
|
|
||
| export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app={{ template "fullname" . }}" -o jsonpath="{.items[0].metadata.name}") |
There was a problem hiding this comment.
"app={{ template "fullname" . }}" -> "app={{ template "name" . }},release={{ .Release.Name }}"
| spec: | ||
| template: | ||
| metadata: | ||
| labels: |
There was a problem hiding this comment.
Only app and release label should be added here.
| port: 443 | ||
| targetPort: https | ||
| selector: | ||
| app: {{ template "name" . }} |
There was a problem hiding this comment.
Add release label to selector.
| containers: | ||
| - name: {{ template "fullname" . }} | ||
| image: "{{ .Values.image }}" | ||
| imagePullPolicy: {{ default "" .Values.imagePullPolicy | quote }} |
| - name: SUITECRM_HOST | ||
| value: {{ include "host" . | quote }} | ||
| - name: SUITECRM_USERNAME | ||
| value: {{ default "" .Values.suitecrmUsername | quote }} |
There was a problem hiding this comment.
No need to add default "" if you add an empty default to values.yml. Apply where applicable in the whole chart.
|
updated! thanks for the review. |
unguiculus
suggested changes
Jul 30, 2017
stable/suitecrm/templates/NOTES.txt
Outdated
|
|
||
| {{- if eq .Values.serviceType "ClusterIP" }} | ||
|
|
||
| export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app={{ template "name" . }}" -o jsonpath="{.items[0].metadata.name}") |
There was a problem hiding this comment.
"app={{ template "name" . }}" -> "app={{ template "name" . }},release={{ .Release.Name }}"
|
updated! |
unguiculus
approved these changes
Jul 31, 2017
unguiculus
added
code reviewed
lgtm
munnerz
added a commit
to munnerz/charts-1
that referenced
this pull request
Feb 5, 2019
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315) * Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296) * Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277) * Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273) * Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260) * Update Chart.yaml in webhook (cert-manager/cert-manager#1249)
munnerz
added a commit
to munnerz/charts-1
that referenced
this pull request
Feb 5, 2019
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315) * Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296) * Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277) * Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273) * Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260) * Update Chart.yaml in webhook (cert-manager/cert-manager#1249) Signed-off-by: James Munnelly <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.