Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] allow to configure operator log level #11326

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

itaysk
Copy link
Contributor

@itaysk itaysk commented Feb 11, 2019

What this PR does / why we need it:

allows to configure operator log level (https://github.com/coreos/prometheus-operator/pull/1277/files)

Which issue this PR fixes

Special notes for your reviewer:

@gianrubio

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2019
@itaysk itaysk force-pushed the operator-log-level branch from 2f28178 to d1878a5 Compare February 11, 2019 14:13
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2019
@vsliouniaev
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 15, 2019
@vsliouniaev
Copy link
Collaborator

/retest all

@vsliouniaev
Copy link
Collaborator

@itaysk can you please bump the chart version again?

@itaysk itaysk force-pushed the operator-log-level branch from d1878a5 to 99328b5 Compare February 15, 2019 17:37
@helm-bot helm-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2019
@itaysk
Copy link
Contributor Author

itaysk commented Feb 15, 2019

done

@vsliouniaev
Copy link
Collaborator

/lgtm
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itaysk, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

@vsliouniaev: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/lgtm
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants