This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Fix gcs credentials location #11189
Merged
Fix gcs credentials location #11189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
size/XS
|
/assign @nitisht |
|
@domcar: GitHub didn't allow me to assign the following users: nitisht. Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
thanks for the PR @domcar , please fix DCO |
|
/approve |
k8s-ci-robot
added
the
approved
Signed-off-by: Domenico Caruso <[email protected]>
Signed-off-by: Domenico Caruso <[email protected]>
helm-bot
added
Contribution Allowed
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: domcar, nitisht The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* Fix gcs credentials location Signed-off-by: Domenico Caruso <[email protected]> * Update patch version Signed-off-by: Domenico Caruso <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* Fix gcs credentials location Signed-off-by: Domenico Caruso <[email protected]> * Update patch version Signed-off-by: Domenico Caruso <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* Fix gcs credentials location Signed-off-by: Domenico Caruso <[email protected]> * Update patch version Signed-off-by: Domenico Caruso <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* Fix gcs credentials location Signed-off-by: Domenico Caruso <[email protected]> * Update patch version Signed-off-by: Domenico Caruso <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* Fix gcs credentials location Signed-off-by: Domenico Caruso <[email protected]> * Update patch version Signed-off-by: Domenico Caruso <[email protected]> Signed-off-by: Samir Musali <[email protected]>
towolf
pushed a commit
to towolf/charts
that referenced
this pull request
Feb 7, 2019
* Fix gcs credentials location Signed-off-by: Domenico Caruso <[email protected]> * Update patch version Signed-off-by: Domenico Caruso <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
At the moment the Chart exports the
GOOGLE_APPLICATION_CREDENTIALSas an env containing the json credentials of the service account.Instead
minio gateway gcsexpects a path where to find the json file.This PR fixes this behaviour.
Checklist
@wlan0 @nitisht Can you please review?