This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/wordpress] Enable configuration of AllowOverride #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier J. Salmeron Garcia <[email protected]>
Signed-off-by: Javier J. Salmeron Garcia <[email protected]>
helm-bot
added
Contribution Allowed
Signed-off-by: Javier J. Salmeron Garcia <[email protected]>
helm-bot
added
size/M
|
/ok-to-test |
|
I'm okay with the changes but let's wait until the WP image that supports the new env. variable is released. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Javier J. Salmeron Garcia <[email protected]>
helm-bot
added
size/M
|
/hold cancel |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: javsalgar, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* [stable/wordpress] Enable configuration of AllowOverride Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add custom htaccess cm Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add helper Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Update allowOverride values Signed-off-by: Javier J. Salmeron Garcia <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* [stable/wordpress] Enable configuration of AllowOverride Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add custom htaccess cm Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add helper Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Update allowOverride values Signed-off-by: Javier J. Salmeron Garcia <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* [stable/wordpress] Enable configuration of AllowOverride Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add custom htaccess cm Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add helper Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Update allowOverride values Signed-off-by: Javier J. Salmeron Garcia <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* [stable/wordpress] Enable configuration of AllowOverride Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add custom htaccess cm Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add helper Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Update allowOverride values Signed-off-by: Javier J. Salmeron Garcia <[email protected]> Signed-off-by: Samir Musali <[email protected]>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
* [stable/wordpress] Enable configuration of AllowOverride Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add custom htaccess cm Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add helper Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Update allowOverride values Signed-off-by: Javier J. Salmeron Garcia <[email protected]> Signed-off-by: Samir Musali <[email protected]>
towolf
pushed a commit
to towolf/charts
that referenced
this pull request
Feb 7, 2019
* [stable/wordpress] Enable configuration of AllowOverride Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add custom htaccess cm Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Add helper Signed-off-by: Javier J. Salmeron Garcia <[email protected]> * Update allowOverride values Signed-off-by: Javier J. Salmeron Garcia <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier J. Salmeron Garcia [email protected]
What this PR does / why we need it:
This PR allows setting Apache
AllowOverridetoNone. This is important for security and performance reasonsWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]