[stable/jenkins] Allow to enable OWASP Markup Formatter Plugin

[375gnu]

Signed-off-by: Hleb Valoshka [email protected]

What this PR does / why we need it:

If one works with ghprb jenkins plugin then data sent but github contains html snippets which are not parsed by default (see janinko/ghprb#140). To workaround this issue one needs to install OWASP Markup Formatter Plugin and to set markup formatter to Safe HTML.

Currently using the chart we can install the required plugins, but Safe HTML should be enabled manually. This PR fixes this inconvenience.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md

[maorfr]

Hey @375gnu,

Happy to see another contribution from you!
Can this PR be simplified? I would expect no changes to _helpers.tpl for example. In addition, can the existing mechanism to install plugins be used?

What do you think?

[maorfr]

/assign

[375gnu]

Hi @maorfr, I've simplified my pr a little. If you are ok with it, i'll squash commits.

My original idea was to make it fool proof that's why it was quite big.

[maorfr]

Thanks for your reply and changes, much appreciated. It is looking much better!

I see that in config.yaml there is a mention of the plugin version. Can this be avoided? If not, we should at least document it.

In addition, I would prefer to not add the plugin installation, but rather document it instead, to avoid changing the default chart installation.

Will that be ok by you?

[375gnu]

Hi @maorfr , I've pushed a new commit addressing your requirements. If the pr looks good now for you I'll rebase it against the current master and squash into a single commit.

[maorfr]

/ok-to-test
Looks good! Thanks for your cooperation :)
Feel free to squash if you want.

[375gnu]

Hi @maorfr , I've squashed and rebased, could you merge it?

[maorfr]

/lgtm

Thanks for contributing!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 375gnu, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/jenkins/OWNERS [maorfr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment