Skip to content

Commit

Permalink
Revert "Support if the help is either stdout or stderr (#64)"
Browse files Browse the repository at this point in the history
This reverts commit 187a774.

Cobra has reverted the change that had the help message go to stderr:
spf13/cobra#1004

Considering what allowed to notice this regression in Cobra was the
failure of Helm's acceptance-testing repo, I prefer to continue have
the test fail if the help ever goes to stderr.
  • Loading branch information
marckhouzam committed Jan 1, 2020
1 parent b819a93 commit 2a90481
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/completion-tests/completionTests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ if [ ! -z ${ROBOT_HELM_V3} ]; then
# Also test that the list of outputs matches what the helm message gives.
# This is an imperfect way of detecting if the output format list has changed, but
# the completion wasn't updated to match.
outputFormats=$(helm repo list -h 2>&1 | grep -- --output | cut -d: -f2 | cut -d '(' -f1 | sed s/,//g)
outputFormats=$(helm repo list -h | grep -- --output | cut -d: -f2 | cut -d '(' -f1 | sed s/,//g)
_completionTests_verifyCompletion "helm repo list --output " "${outputFormats}"
_completionTests_verifyCompletion "helm install --output " "${outputFormats}"
_completionTests_verifyCompletion "helm history -o " "${outputFormats}"
Expand Down

0 comments on commit 2a90481

Please sign in to comment.