From 7fa7896bc1433e2c89f20a2118da02afc0f910df Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Tue, 25 Jul 2023 19:54:03 -0400
Subject: [PATCH 01/29] ignore runtime symlink

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 6a6fc782a827..548c664fe8c8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,3 +3,4 @@ target
 helix-term/rustfmt.toml
 result
 runtime/grammars
+runtime
\ No newline at end of file

From 4e010882120aa521e573497b5162db3abaa7d14d Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Tue, 25 Jul 2023 20:07:40 -0400
Subject: [PATCH 02/29] added is_read_only and "[readonly]" to statusline

---
 helix-term/src/ui/statusline.rs |  8 +++++---
 helix-view/src/document.rs      | 10 ++++++++++
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index 61fca609b208..04c1e9363129 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -432,12 +432,14 @@ fn render_file_modification_indicator<F>(context: &mut RenderContext, write: F)
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
-    let title = (if context.doc.is_modified() {
+    debug_assert!(!(context.doc.is_read_only() && context.doc.is_modified()));
+    let title = (if context.doc.is_read_only() {
+        "[readonly]"
+    } else if context.doc.is_modified() {
         "[+]"
     } else {
         "   "
-    })
-    .to_string();
+    }).to_string();
 
     write(context, title, None);
 }
diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs
index af7e3a7e80d1..46a20f679dd9 100644
--- a/helix-view/src/document.rs
+++ b/helix-view/src/document.rs
@@ -1420,6 +1420,16 @@ impl Document {
         self.id
     }
 
+    pub fn is_read_only(&self) -> bool {
+        match &self.path {
+            None => false,
+            Some(p) => match std::fs::metadata(p) {
+                Err(_) => false,
+                Ok(metadata) => metadata.permissions().readonly(),
+            },
+        }
+    }
+
     /// If there are unsaved modifications.
     pub fn is_modified(&self) -> bool {
         let history = self.history.take();

From 141a16222fca9956de6301e1e189e0c93f498484 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Tue, 25 Jul 2023 21:08:11 -0400
Subject: [PATCH 03/29] change to check if readonly on set_path()

---
 helix-term/src/ui/statusline.rs |  4 ++--
 helix-view/src/document.rs      | 23 +++++++++++++----------
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index 04c1e9363129..044a32c929a7 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -432,8 +432,8 @@ fn render_file_modification_indicator<F>(context: &mut RenderContext, write: F)
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
-    debug_assert!(!(context.doc.is_read_only() && context.doc.is_modified()));
-    let title = (if context.doc.is_read_only() {
+    debug_assert!(!(context.doc.readonly.unwrap_or(false) && context.doc.is_modified()));
+    let title = (if context.doc.readonly.unwrap_or(false) {
         "[readonly]"
     } else if context.doc.is_modified() {
         "[+]"
diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs
index 46a20f679dd9..978a27b6de30 100644
--- a/helix-view/src/document.rs
+++ b/helix-view/src/document.rs
@@ -185,6 +185,9 @@ pub struct Document {
 
     // when document was used for most-recent-used buffer picker
     pub focused_at: std::time::Instant,
+
+    // logically true when equal to Some(true); None implies we haven't checked yet
+    pub readonly: Option<bool>,
 }
 
 /// Inlay hints for a single `(Document, View)` combo.
@@ -673,6 +676,7 @@ impl Document {
             config,
             version_control_head: None,
             focused_at: std::time::Instant::now(),
+            readonly: None
         }
     }
 
@@ -1018,6 +1022,15 @@ impl Document {
         // and error out when document is saved
         self.path = path;
 
+        // Check if the file is readonly or not
+        self.readonly = Some(match &self.path {
+            None => false,
+            Some(p) => match std::fs::metadata(p) {
+                Err(_) => false,
+                Ok(metadata) => metadata.permissions().readonly(),
+            },
+        });
+
         Ok(())
     }
 
@@ -1420,16 +1433,6 @@ impl Document {
         self.id
     }
 
-    pub fn is_read_only(&self) -> bool {
-        match &self.path {
-            None => false,
-            Some(p) => match std::fs::metadata(p) {
-                Err(_) => false,
-                Ok(metadata) => metadata.permissions().readonly(),
-            },
-        }
-    }
-
     /// If there are unsaved modifications.
     pub fn is_modified(&self) -> bool {
         let history = self.history.take();

From d17992cf2c75e566664ae02910f7af4104591230 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Thu, 27 Jul 2023 18:49:51 -0400
Subject: [PATCH 04/29] undo first commit gitignore mess up

---
 .gitignore      | 3 +--
 runtime/runtime | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)
 create mode 120000 runtime/runtime

diff --git a/.gitignore b/.gitignore
index 548c664fe8c8..75fc882ed261 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,5 +2,4 @@ target
 .direnv
 helix-term/rustfmt.toml
 result
-runtime/grammars
-runtime
\ No newline at end of file
+runtime/grammars
\ No newline at end of file
diff --git a/runtime/runtime b/runtime/runtime
new file mode 120000
index 000000000000..a439b2699a3f
--- /dev/null
+++ b/runtime/runtime
@@ -0,0 +1 @@
+/home/connor/opt/helix/runtime
\ No newline at end of file

From 407959d4e30b70fae4eb712ba76ccccf342f8387 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Thu, 27 Jul 2023 18:56:40 -0400
Subject: [PATCH 05/29] change Document readonly field to bool

---
 helix-term/src/ui/statusline.rs | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index 044a32c929a7..cf19457002c6 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -432,14 +432,12 @@ fn render_file_modification_indicator<F>(context: &mut RenderContext, write: F)
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
-    debug_assert!(!(context.doc.readonly.unwrap_or(false) && context.doc.is_modified()));
-    let title = (if context.doc.readonly.unwrap_or(false) {
-        "[readonly]"
-    } else if context.doc.is_modified() {
-        "[+]"
-    } else {
-        "   "
-    }).to_string();
+    let title = match (context.doc.readonly, context.doc.is_modified()) {
+        (false, false) => "   ",
+        (false, true) => "[+]",
+        (true, false) => "[readonly]",
+        (true, true) => "Warning: Changing a readonly file",
+    }.to_string();
 
     write(context, title, None);
 }

From 4696692900f33865e480efae27f6e7ba072dd0d7 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sat, 29 Jul 2023 11:12:08 -0400
Subject: [PATCH 06/29] readonly check on write_impl and write_all_impl

---
 helix-term/src/commands/typed.rs | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index 67640f79764f..9400664a9f08 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -334,6 +334,10 @@ fn write_impl(
     let (view, doc) = current!(cx.editor);
     let path = path.map(AsRef::as_ref);
 
+    if doc.detect_readonly() && !force {
+        bail!("'readonly' option is set (add ! to overwrite)")
+    }
+
     let fmt = if editor_auto_fmt {
         doc.auto_format().map(|fmt| {
             let callback = make_format_callback(
@@ -676,6 +680,12 @@ pub fn write_all_impl(
                 }
                 return None;
             }
+            if doc.detect_readonly() && !force {
+                if write_scratch {
+                    errors.push("'readonly' option is set (add ! to overwrite)");
+                }
+                return None;
+            }
 
             // Look for a view to apply the formatting change to. If the document
             // is in the current view, just use that. Otherwise, since we don't

From 6ad36ba965a1915dfe28b171e1e39935312f9d9d Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sat, 29 Jul 2023 12:41:54 -0400
Subject: [PATCH 07/29] add readonly indicator element on statusline

plus separate render function for readonly
---
 helix-term/src/ui/statusline.rs | 71 +++++++++++++++++++--------------
 helix-view/src/editor.rs        |  4 ++
 2 files changed, 46 insertions(+), 29 deletions(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index cf19457002c6..f84a68bacac5 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -137,30 +137,28 @@ fn get_render_function<F>(element_id: StatusLineElementID) -> impl Fn(&mut Rende
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
+    use helix_view::editor::StatusLineElement as E;
     match element_id {
-        helix_view::editor::StatusLineElement::Mode => render_mode,
-        helix_view::editor::StatusLineElement::Spinner => render_lsp_spinner,
-        helix_view::editor::StatusLineElement::FileBaseName => render_file_base_name,
-        helix_view::editor::StatusLineElement::FileName => render_file_name,
-        helix_view::editor::StatusLineElement::FileModificationIndicator => {
-            render_file_modification_indicator
-        }
-        helix_view::editor::StatusLineElement::FileEncoding => render_file_encoding,
-        helix_view::editor::StatusLineElement::FileLineEnding => render_file_line_ending,
-        helix_view::editor::StatusLineElement::FileType => render_file_type,
-        helix_view::editor::StatusLineElement::Diagnostics => render_diagnostics,
-        helix_view::editor::StatusLineElement::WorkspaceDiagnostics => render_workspace_diagnostics,
-        helix_view::editor::StatusLineElement::Selections => render_selections,
-        helix_view::editor::StatusLineElement::PrimarySelectionLength => {
-            render_primary_selection_length
-        }
-        helix_view::editor::StatusLineElement::Position => render_position,
-        helix_view::editor::StatusLineElement::PositionPercentage => render_position_percentage,
-        helix_view::editor::StatusLineElement::TotalLineNumbers => render_total_line_numbers,
-        helix_view::editor::StatusLineElement::Separator => render_separator,
-        helix_view::editor::StatusLineElement::Spacer => render_spacer,
-        helix_view::editor::StatusLineElement::VersionControl => render_version_control,
-        helix_view::editor::StatusLineElement::Register => render_register,
+        E::Mode => render_mode,
+        E::Spinner => render_lsp_spinner,
+        E::FileBaseName => render_file_base_name,
+        E::FileName => render_file_name,
+        E::FileModificationIndicator => render_file_modification_indicator,
+        E::ReadOnlyIndicator => render_read_only_indicator,
+        E::FileEncoding => render_file_encoding,
+        E::FileLineEnding => render_file_line_ending,
+        E::FileType => render_file_type,
+        E::Diagnostics => render_diagnostics,
+        E::WorkspaceDiagnostics => render_workspace_diagnostics,
+        E::Selections => render_selections,
+        E::PrimarySelectionLength => render_primary_selection_length,
+        E::Position => render_position,
+        E::PositionPercentage => render_position_percentage,
+        E::TotalLineNumbers => render_total_line_numbers,
+        E::Separator => render_separator,
+        E::Spacer => render_spacer,
+        E::VersionControl => render_version_control,
+        E::Register => render_register,
     }
 }
 
@@ -432,16 +430,31 @@ fn render_file_modification_indicator<F>(context: &mut RenderContext, write: F)
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
-    let title = match (context.doc.readonly, context.doc.is_modified()) {
-        (false, false) => "   ",
-        (false, true) => "[+]",
-        (true, false) => "[readonly]",
-        (true, true) => "Warning: Changing a readonly file",
-    }.to_string();
+    let title = (if context.doc.is_modified() {
+        "[+] "
+    } else {
+        " "
+    })
+    .to_string();
 
     write(context, title, None);
 }
 
+fn render_read_only_indicator<F>(context: &mut RenderContext, write: F)
+where
+    F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
+{
+    let (title, style) = match (context.doc.readonly, context.doc.is_modified()) {
+        (true, false) => ("[readonly]", None),
+        (true, true) => (
+            "Warning: Changing a readonly file",
+            Some(context.editor.theme.get("warning")),
+        ),
+        _ => ("", None),
+    };
+    write(context, title.to_string(), style);
+}
+
 fn render_file_base_name<F>(context: &mut RenderContext, write: F)
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
diff --git a/helix-view/src/editor.rs b/helix-view/src/editor.rs
index 2152ff9bbcee..9e375eba4f82 100644
--- a/helix-view/src/editor.rs
+++ b/helix-view/src/editor.rs
@@ -422,6 +422,7 @@ impl Default for StatusLineConfig {
                 E::Spinner,
                 E::FileName,
                 E::FileModificationIndicator,
+                E::ReadOnlyIndicator,
             ],
             center: vec![],
             right: vec![
@@ -473,6 +474,9 @@ pub enum StatusLineElement {
     // The file modification indicator
     FileModificationIndicator,
 
+    /// A read only file indicator
+    ReadOnlyIndicator,
+
     /// The file encoding
     FileEncoding,
 

From 9b4010dd6fc83a08c9ebf82587ad3c977243609c Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sat, 29 Jul 2023 13:01:49 -0400
Subject: [PATCH 08/29] use access syscall for unix readonly

---
 Cargo.lock                 |  1 +
 helix-view/Cargo.toml      |  1 +
 helix-view/src/document.rs | 39 +++++++++++++++++++++++++++-----------
 3 files changed, 30 insertions(+), 11 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 9a7dee720cb7..128d8825f312 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1392,6 +1392,7 @@ dependencies = [
  "log",
  "once_cell",
  "parking_lot",
+ "rustix 0.38.4",
  "serde",
  "serde_json",
  "slotmap",
diff --git a/helix-view/Cargo.toml b/helix-view/Cargo.toml
index 203b5dad3647..e375b080bba7 100644
--- a/helix-view/Cargo.toml
+++ b/helix-view/Cargo.toml
@@ -16,6 +16,7 @@ term = ["crossterm"]
 [dependencies]
 bitflags = "2.3"
 anyhow = "1"
+rustix = { version = "0.38", features = ["fs"] }
 helix-core = { version = "0.6", path = "../helix-core" }
 helix-loader = { version = "0.6", path = "../helix-loader" }
 helix-lsp = { version = "0.6", path = "../helix-lsp" }
diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs
index 978a27b6de30..b116535ce588 100644
--- a/helix-view/src/document.rs
+++ b/helix-view/src/document.rs
@@ -186,8 +186,7 @@ pub struct Document {
     // when document was used for most-recent-used buffer picker
     pub focused_at: std::time::Instant,
 
-    // logically true when equal to Some(true); None implies we haven't checked yet
-    pub readonly: Option<bool>,
+    pub readonly: bool,
 }
 
 /// Inlay hints for a single `(Document, View)` combo.
@@ -676,7 +675,7 @@ impl Document {
             config,
             version_control_head: None,
             focused_at: std::time::Instant::now(),
-            readonly: None
+            readonly: false,
         }
     }
 
@@ -959,6 +958,28 @@ impl Document {
         }
     }
 
+    // Detect if the file is readonly and change the readonly field if necessary
+    pub fn detect_readonly(&mut self) -> bool {
+        if cfg!(unix) {
+            use rustix::fs::{access, Access};
+            // Allows setting the flag for files the user cannot modify, like root files
+            self.readonly = match &self.path {
+                None => false,
+                Some(p) => access(p, Access::WRITE_OK).is_err(),
+            }
+        } else {
+            // TODO use windows-sys or https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-accesscheck
+            self.readonly = match &self.path {
+                None => false,
+                Some(p) => match std::fs::metadata(p) {
+                    Err(_) => false,
+                    Ok(metadata) => metadata.permissions().readonly(),
+                },
+            }
+        }
+        self.readonly
+    }
+
     /// Reload the document from its path.
     pub fn reload(
         &mut self,
@@ -973,6 +994,9 @@ impl Document {
             .ok_or_else(|| anyhow!("can't find file to reload from {:?}", self.display_name()))?
             .to_owned();
 
+        // Once we have a valid path we check if its readonly status has changed
+        self.detect_readonly();
+
         let mut file = std::fs::File::open(&path)?;
         let (rope, ..) = from_reader(&mut file, Some(encoding))?;
 
@@ -1022,14 +1046,7 @@ impl Document {
         // and error out when document is saved
         self.path = path;
 
-        // Check if the file is readonly or not
-        self.readonly = Some(match &self.path {
-            None => false,
-            Some(p) => match std::fs::metadata(p) {
-                Err(_) => false,
-                Ok(metadata) => metadata.permissions().readonly(),
-            },
-        });
+        self.detect_readonly();
 
         Ok(())
     }

From 0059cceb58797dda29105883e726debfc836e5ed Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sat, 29 Jul 2023 13:13:33 -0400
Subject: [PATCH 09/29] spacing corrected for statusline text

---
 helix-term/src/ui/statusline.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index f84a68bacac5..9e51d8f318f9 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -431,9 +431,9 @@ where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
     let title = (if context.doc.is_modified() {
-        "[+] "
+        " [+] "
     } else {
-        " "
+        ""
     })
     .to_string();
 
@@ -445,9 +445,9 @@ where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
     let (title, style) = match (context.doc.readonly, context.doc.is_modified()) {
-        (true, false) => ("[readonly]", None),
+        (true, false) => (" [readonly] ", None),
         (true, true) => (
-            "Warning: Changing a readonly file",
+            " Warning: Changing a readonly file ",
             Some(context.editor.theme.get("warning")),
         ),
         _ => ("", None),

From d23252ee7cf423bd09df4382fb84a5fcca6cf3ba Mon Sep 17 00:00:00 2001
From: Connortsui20 <87130162+Connortsui20@users.noreply.github.com>
Date: Sat, 29 Jul 2023 13:42:54 -0400
Subject: [PATCH 10/29] delete runtime

Not sure how this got in here
---
 runtime/runtime | 1 -
 1 file changed, 1 deletion(-)
 delete mode 120000 runtime/runtime

diff --git a/runtime/runtime b/runtime/runtime
deleted file mode 120000
index a439b2699a3f..000000000000
--- a/runtime/runtime
+++ /dev/null
@@ -1 +0,0 @@
-/home/connor/opt/helix/runtime
\ No newline at end of file

From e01f1e796916f78bec52b123bedd60abe95a9c69 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sat, 29 Jul 2023 14:28:00 -0400
Subject: [PATCH 11/29] Add todo message for windows readonly

---
 helix-view/src/document.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs
index b116535ce588..a5a5fd725b56 100644
--- a/helix-view/src/document.rs
+++ b/helix-view/src/document.rs
@@ -968,7 +968,10 @@ impl Document {
                 Some(p) => access(p, Access::WRITE_OK).is_err(),
             }
         } else {
-            // TODO use windows-sys or https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-accesscheck
+            // TODO Use the Windows' function `CreateFileW` to check if a file is readonly
+            // Discussion: https://github.com/helix-editor/helix/pull/7740#issuecomment-1656806459
+            // Vim implementation: https://github.com/vim/vim/blob/4c0089d696b8d1d5dc40568f25ea5738fa5bbffb/src/os_win32.c#L7665
+            // Windows binding: https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Storage/FileSystem/fn.CreateFileW.html
             self.readonly = match &self.path {
                 None => false,
                 Some(p) => match std::fs::metadata(p) {

From 7ecaf745e8cad2f5c0efe542b5fe7d5ecbd9f2c1 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sat, 29 Jul 2023 15:36:50 -0400
Subject: [PATCH 12/29] added error list of readonly files on write-all

---
 helix-term/src/commands/typed.rs | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index 9400664a9f08..0f3ee5518541 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -660,7 +660,8 @@ pub fn write_all_impl(
     force: bool,
     write_scratch: bool,
 ) -> anyhow::Result<()> {
-    let mut errors: Vec<&'static str> = Vec::new();
+    let mut errors: Vec<String> = Vec::new();
+    let mut readonly_errors: Vec<String> = Vec::new();
     let auto_format = cx.editor.config().auto_format;
     let jobs = &mut cx.jobs;
     let current_view = view!(cx.editor);
@@ -676,13 +677,17 @@ pub fn write_all_impl(
             }
             if doc.path().is_none() {
                 if write_scratch {
-                    errors.push("cannot write a buffer without a filename\n");
+                    errors.push("cannot write a buffer without a filename".to_string());
                 }
                 return None;
             }
             if doc.detect_readonly() && !force {
                 if write_scratch {
-                    errors.push("'readonly' option is set (add ! to overwrite)");
+                    readonly_errors.push(format!(
+                        "'readonly' option is set for {:?}",
+                        // Safety: doc.path() is checked to not be None in the if statement above
+                        doc.path().unwrap()
+                    ).replace('"', ""));
                 }
                 return None;
             }
@@ -730,8 +735,19 @@ pub fn write_all_impl(
         cx.editor.save::<PathBuf>(id, None, force)?;
     }
 
-    if !errors.is_empty() && !force {
-        bail!("{:?}", errors);
+    if force {
+        return Ok(());
+    }
+
+    let mut error_msg = errors.join(" ");
+    if !readonly_errors.is_empty() {
+        // statusline text will have the form:
+        // ["'readonly' option is set for /home/user/readonly.txt", ...] (add ! to overwrite)
+        error_msg = format!("{:?} (add ! to overwrite)", readonly_errors);
+    }
+
+    if !error_msg.is_empty() && !force {
+        bail!(error_msg);
     }
 
     Ok(())

From dfa11dc8ae290b42e12457f0e69bacc5ffe32767 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 12:04:36 -0400
Subject: [PATCH 13/29] shorthand change back

---
 helix-term/src/ui/statusline.rs | 45 ++++++++++++++++++---------------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index 9e51d8f318f9..69d63704cd6d 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -137,28 +137,31 @@ fn get_render_function<F>(element_id: StatusLineElementID) -> impl Fn(&mut Rende
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
-    use helix_view::editor::StatusLineElement as E;
     match element_id {
-        E::Mode => render_mode,
-        E::Spinner => render_lsp_spinner,
-        E::FileBaseName => render_file_base_name,
-        E::FileName => render_file_name,
-        E::FileModificationIndicator => render_file_modification_indicator,
-        E::ReadOnlyIndicator => render_read_only_indicator,
-        E::FileEncoding => render_file_encoding,
-        E::FileLineEnding => render_file_line_ending,
-        E::FileType => render_file_type,
-        E::Diagnostics => render_diagnostics,
-        E::WorkspaceDiagnostics => render_workspace_diagnostics,
-        E::Selections => render_selections,
-        E::PrimarySelectionLength => render_primary_selection_length,
-        E::Position => render_position,
-        E::PositionPercentage => render_position_percentage,
-        E::TotalLineNumbers => render_total_line_numbers,
-        E::Separator => render_separator,
-        E::Spacer => render_spacer,
-        E::VersionControl => render_version_control,
-        E::Register => render_register,
+        helix_view::editor::StatusLineElement::Mode => render_mode,
+        helix_view::editor::StatusLineElement::Spinner => render_lsp_spinner,
+        helix_view::editor::StatusLineElement::FileBaseName => render_file_base_name,
+        helix_view::editor::StatusLineElement::FileName => render_file_name,
+        helix_view::editor::StatusLineElement::FileModificationIndicator => {
+            render_file_modification_indicator
+        }
+        helix_view::editor::StatusLineElement::ReadOnlyIndicator => render_read_only_indicator,
+        helix_view::editor::StatusLineElement::FileEncoding => render_file_encoding,
+        helix_view::editor::StatusLineElement::FileLineEnding => render_file_line_ending,
+        helix_view::editor::StatusLineElement::FileType => render_file_type,
+        helix_view::editor::StatusLineElement::Diagnostics => render_diagnostics,
+        helix_view::editor::StatusLineElement::WorkspaceDiagnostics => render_workspace_diagnostics,
+        helix_view::editor::StatusLineElement::Selections => render_selections,
+        helix_view::editor::StatusLineElement::PrimarySelectionLength => {
+            render_primary_selection_length
+        }
+        helix_view::editor::StatusLineElement::Position => render_position,
+        helix_view::editor::StatusLineElement::PositionPercentage => render_position_percentage,
+        helix_view::editor::StatusLineElement::TotalLineNumbers => render_total_line_numbers,
+        helix_view::editor::StatusLineElement::Separator => render_separator,
+        helix_view::editor::StatusLineElement::Spacer => render_spacer,
+        helix_view::editor::StatusLineElement::VersionControl => render_version_control,
+        helix_view::editor::StatusLineElement::Register => render_register,
     }
 }
 

From 07002543bb55cc4d3636f6d8fca2a5d951189634 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 12:17:25 -0400
Subject: [PATCH 14/29] clearer readonly message

---
 helix-term/src/commands/typed.rs | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index 0f3ee5518541..d434d89d75ec 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -334,8 +334,9 @@ fn write_impl(
     let (view, doc) = current!(cx.editor);
     let path = path.map(AsRef::as_ref);
 
-    if doc.detect_readonly() && !force {
-        bail!("'readonly' option is set (add ! to overwrite)")
+    // `path.is_none()` allows :w <path> for other files
+    if path.is_none() && doc.detect_readonly() && !force {
+        bail!("file is readonly, use ! to overwrite")
     }
 
     let fmt = if editor_auto_fmt {
@@ -683,11 +684,14 @@ pub fn write_all_impl(
             }
             if doc.detect_readonly() && !force {
                 if write_scratch {
-                    readonly_errors.push(format!(
-                        "'readonly' option is set for {:?}",
-                        // Safety: doc.path() is checked to not be None in the if statement above
-                        doc.path().unwrap()
-                    ).replace('"', ""));
+                    readonly_errors.push(
+                        format!(
+                            "{:?} is readonly",
+                            // Safety: doc.path() cannot be None from the if statement above
+                            doc.path().unwrap()
+                        )
+                        .replace('"', ""),
+                    );
                 }
                 return None;
             }
@@ -742,11 +746,11 @@ pub fn write_all_impl(
     let mut error_msg = errors.join(" ");
     if !readonly_errors.is_empty() {
         // statusline text will have the form:
-        // ["'readonly' option is set for /home/user/readonly.txt", ...] (add ! to overwrite)
-        error_msg = format!("{:?} (add ! to overwrite)", readonly_errors);
+        // [/home/user/readonly.txt is readonly, ..., /readonly2.txt is readonly] add ! to overwrite
+        error_msg = format!("{:?} use ! to overwrite", readonly_errors).replace('"', "");
     }
 
-    if !error_msg.is_empty() && !force {
+    if !error_msg.is_empty() {
         bail!(error_msg);
     }
 

From 7f18081b135b21f6161be74837ee31b5e4576e78 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 12:36:40 -0400
Subject: [PATCH 15/29] change rustix dep for unix only

---
 helix-view/Cargo.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helix-view/Cargo.toml b/helix-view/Cargo.toml
index e375b080bba7..b66739a4a22e 100644
--- a/helix-view/Cargo.toml
+++ b/helix-view/Cargo.toml
@@ -16,7 +16,6 @@ term = ["crossterm"]
 [dependencies]
 bitflags = "2.3"
 anyhow = "1"
-rustix = { version = "0.38", features = ["fs"] }
 helix-core = { version = "0.6", path = "../helix-core" }
 helix-loader = { version = "0.6", path = "../helix-loader" }
 helix-lsp = { version = "0.6", path = "../helix-lsp" }
@@ -52,6 +51,7 @@ clipboard-win = { version = "4.5", features = ["std"] }
 
 [target.'cfg(unix)'.dependencies]
 libc = "0.2"
+rustix = { version = "0.38", features = ["fs"] }
 
 [dev-dependencies]
 helix-tui = { path = "../helix-tui" }

From d593548441e3aa0f9a0656b90d4d878b0c6c7db2 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 13:07:03 -0400
Subject: [PATCH 16/29] add read-only-indicator to docs

---
 book/src/configuration.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/book/src/configuration.md b/book/src/configuration.md
index 4c152bf4da48..62a642095062 100644
--- a/book/src/configuration.md
+++ b/book/src/configuration.md
@@ -89,7 +89,7 @@ The `[editor.statusline]` key takes the following sub-keys:
 
 | Key           | Description | Default |
 | ---           | ---         | ---     |
-| `left`        | A list of elements aligned to the left of the statusline | `["mode", "spinner", "file-name", "file-modification-indicator"]` |
+| `left`        | A list of elements aligned to the left of the statusline | `["mode", "spinner", "file-name", "file-modification-indicator", "read-only-indicator"]` |
 | `center`      | A list of elements aligned to the middle of the statusline | `[]` |
 | `right`       | A list of elements aligned to the right of the statusline | `["diagnostics", "selections", "register", "position", "file-encoding"]` |
 | `separator`   | The character used to separate elements in the statusline | `"│"` |
@@ -108,6 +108,7 @@ The following statusline elements can be configured:
 | `file-modification-indicator` | The indicator to show whether the file is modified (a `[+]` appears when there are unsaved changes) |
 | `file-encoding` | The encoding of the opened file if it differs from UTF-8 |
 | `file-line-ending` | The file line endings (CRLF or LF) |
+| `read-only-indicator` | The indicator to show whether a file is read only |
 | `total-line-numbers` | The total line numbers of the opened file |
 | `file-type` | The type of the opened file |
 | `diagnostics` | The number of warnings and/or errors |

From d9faba84882f585a3e758605d7d8a1bef74930a3 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 13:23:45 -0400
Subject: [PATCH 17/29] added back newline to .gitignore

---
 .gitignore | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index 75fc882ed261..6a6fc782a827 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,4 +2,4 @@ target
 .direnv
 helix-term/rustfmt.toml
 result
-runtime/grammars
\ No newline at end of file
+runtime/grammars

From c2361a4c362b28311d45dc72329bb88cc570a1db Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 14:44:00 -0400
Subject: [PATCH 18/29] change spacing on no file modification

---
 helix-term/src/ui/statusline.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index 69d63704cd6d..5c2d8af5f4cd 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -436,7 +436,7 @@ where
     let title = (if context.doc.is_modified() {
         " [+] "
     } else {
-        ""
+        "     "
     })
     .to_string();
 

From 5cd5baacc2047eb60c46a400f359004032627af1 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 15:50:34 -0400
Subject: [PATCH 19/29] change detect_readonly() for windows compilation

---
 helix-view/src/document.rs | 46 +++++++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 21 deletions(-)

diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs
index a5a5fd725b56..eb7ad2e49511 100644
--- a/helix-view/src/document.rs
+++ b/helix-view/src/document.rs
@@ -958,28 +958,32 @@ impl Document {
         }
     }
 
-    // Detect if the file is readonly and change the readonly field if necessary
+    #[cfg(unix)]
+    // Detect if the file is readonly and change the readonly field if necessary (unix only)
     pub fn detect_readonly(&mut self) -> bool {
-        if cfg!(unix) {
-            use rustix::fs::{access, Access};
-            // Allows setting the flag for files the user cannot modify, like root files
-            self.readonly = match &self.path {
-                None => false,
-                Some(p) => access(p, Access::WRITE_OK).is_err(),
-            }
-        } else {
-            // TODO Use the Windows' function `CreateFileW` to check if a file is readonly
-            // Discussion: https://github.com/helix-editor/helix/pull/7740#issuecomment-1656806459
-            // Vim implementation: https://github.com/vim/vim/blob/4c0089d696b8d1d5dc40568f25ea5738fa5bbffb/src/os_win32.c#L7665
-            // Windows binding: https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Storage/FileSystem/fn.CreateFileW.html
-            self.readonly = match &self.path {
-                None => false,
-                Some(p) => match std::fs::metadata(p) {
-                    Err(_) => false,
-                    Ok(metadata) => metadata.permissions().readonly(),
-                },
-            }
-        }
+        use rustix::fs::{access, Access};
+        // Allows setting the flag for files the user cannot modify, like root files
+        self.readonly = match &self.path {
+            None => false,
+            Some(p) => access(p, Access::WRITE_OK).is_err(),
+        };
+        self.readonly
+    }
+
+    #[cfg(not(unix))]
+    // Detect if the file is readonly and change the readonly field if necessary (non-unix os)
+    pub fn detect_readonly(&mut self) -> bool {
+        // TODO Use the Windows' function `CreateFileW` to check if a file is readonly
+        // Discussion: https://github.com/helix-editor/helix/pull/7740#issuecomment-1656806459
+        // Vim implementation: https://github.com/vim/vim/blob/4c0089d696b8d1d5dc40568f25ea5738fa5bbffb/src/os_win32.c#L7665
+        // Windows binding: https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Storage/FileSystem/fn.CreateFileW.html
+        self.readonly = match &self.path {
+            None => false,
+            Some(p) => match std::fs::metadata(p) {
+                Err(_) => false,
+                Ok(metadata) => metadata.permissions().readonly(),
+            },
+        };
         self.readonly
     }
 

From c048345fbcf910c9bebba36cbf7d06590ff19af2 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 15:56:38 -0400
Subject: [PATCH 20/29] reorder default statusline

---
 helix-view/src/editor.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helix-view/src/editor.rs b/helix-view/src/editor.rs
index 9e375eba4f82..5936d5f14809 100644
--- a/helix-view/src/editor.rs
+++ b/helix-view/src/editor.rs
@@ -421,8 +421,8 @@ impl Default for StatusLineConfig {
                 E::Mode,
                 E::Spinner,
                 E::FileName,
-                E::FileModificationIndicator,
                 E::ReadOnlyIndicator,
+                E::FileModificationIndicator,
             ],
             center: vec![],
             right: vec![

From 48600f5b76531df939c42a4b9704f541f7610fec Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sun, 30 Jul 2023 19:37:21 -0400
Subject: [PATCH 21/29] remove extra spaces

---
 helix-term/src/ui/statusline.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index 5c2d8af5f4cd..8f71e1f723d1 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -434,9 +434,9 @@ where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
     let title = (if context.doc.is_modified() {
-        " [+] "
+        "[+]"
     } else {
-        "     "
+        "   "
     })
     .to_string();
 

From bbcbdfefe8f927cac6dfdb1ad8b6c990be297cf6 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Thu, 3 Aug 2023 20:04:45 -0400
Subject: [PATCH 22/29] simplicity and comment fixes

---
 book/src/configuration.md       |  2 +-
 helix-term/src/ui/statusline.rs | 15 ++++++---------
 helix-view/src/editor.rs        |  2 +-
 3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/book/src/configuration.md b/book/src/configuration.md
index 62a642095062..d24b9ed11df5 100644
--- a/book/src/configuration.md
+++ b/book/src/configuration.md
@@ -89,7 +89,7 @@ The `[editor.statusline]` key takes the following sub-keys:
 
 | Key           | Description | Default |
 | ---           | ---         | ---     |
-| `left`        | A list of elements aligned to the left of the statusline | `["mode", "spinner", "file-name", "file-modification-indicator", "read-only-indicator"]` |
+| `left`        | A list of elements aligned to the left of the statusline | `["mode", "spinner", "file-name", "read-only-indicator", "file-modification-indicator"]` |
 | `center`      | A list of elements aligned to the middle of the statusline | `[]` |
 | `right`       | A list of elements aligned to the right of the statusline | `["diagnostics", "selections", "register", "position", "file-encoding"]` |
 | `separator`   | The character used to separate elements in the statusline | `"│"` |
diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index 8f71e1f723d1..c2f5636230c4 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -447,15 +447,12 @@ fn render_read_only_indicator<F>(context: &mut RenderContext, write: F)
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
-    let (title, style) = match (context.doc.readonly, context.doc.is_modified()) {
-        (true, false) => (" [readonly] ", None),
-        (true, true) => (
-            " Warning: Changing a readonly file ",
-            Some(context.editor.theme.get("warning")),
-        ),
-        _ => ("", None),
-    };
-    write(context, title.to_string(), style);
+    let title = if context.doc.readonly {
+        " [readonly] "
+    } else {
+        ""
+    }.to_string();
+    write(context, title, None);
 }
 
 fn render_file_base_name<F>(context: &mut RenderContext, write: F)
diff --git a/helix-view/src/editor.rs b/helix-view/src/editor.rs
index 5936d5f14809..113102b6b008 100644
--- a/helix-view/src/editor.rs
+++ b/helix-view/src/editor.rs
@@ -474,7 +474,7 @@ pub enum StatusLineElement {
     // The file modification indicator
     FileModificationIndicator,
 
-    /// A read only file indicator
+    /// An indicator that shows `"[readonly]"` when a file cannot be written
     ReadOnlyIndicator,
 
     /// The file encoding

From f54f2f326bc9085a78e1706109702fdc775fe5c3 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Thu, 3 Aug 2023 20:10:03 -0400
Subject: [PATCH 23/29] remove force checks

---
 helix-term/src/commands/typed.rs | 44 ++++++++++++++------------------
 helix-view/src/document.rs       |  6 ++---
 2 files changed, 21 insertions(+), 29 deletions(-)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index d434d89d75ec..7cf24fb69b98 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -334,11 +334,6 @@ fn write_impl(
     let (view, doc) = current!(cx.editor);
     let path = path.map(AsRef::as_ref);
 
-    // `path.is_none()` allows :w <path> for other files
-    if path.is_none() && doc.detect_readonly() && !force {
-        bail!("file is readonly, use ! to overwrite")
-    }
-
     let fmt = if editor_auto_fmt {
         doc.auto_format().map(|fmt| {
             let callback = make_format_callback(
@@ -662,7 +657,6 @@ pub fn write_all_impl(
     write_scratch: bool,
 ) -> anyhow::Result<()> {
     let mut errors: Vec<String> = Vec::new();
-    let mut readonly_errors: Vec<String> = Vec::new();
     let auto_format = cx.editor.config().auto_format;
     let jobs = &mut cx.jobs;
     let current_view = view!(cx.editor);
@@ -682,19 +676,19 @@ pub fn write_all_impl(
                 }
                 return None;
             }
-            if doc.detect_readonly() && !force {
-                if write_scratch {
-                    readonly_errors.push(
-                        format!(
-                            "{:?} is readonly",
-                            // Safety: doc.path() cannot be None from the if statement above
-                            doc.path().unwrap()
-                        )
-                        .replace('"', ""),
-                    );
-                }
-                return None;
-            }
+            // if doc.detect_readonly() && !force {
+            //     if write_scratch {
+            //         readonly_errors.push(
+            //             format!(
+            //                 "{:?} is readonly",
+            //                 // Safety: doc.path() cannot be None from the if statement above
+            //                 doc.path().unwrap()
+            //             )
+            //             .replace('"', ""),
+            //         );
+            //     }
+            //     return None;
+            // }
 
             // Look for a view to apply the formatting change to. If the document
             // is in the current view, just use that. Otherwise, since we don't
@@ -743,12 +737,12 @@ pub fn write_all_impl(
         return Ok(());
     }
 
-    let mut error_msg = errors.join(" ");
-    if !readonly_errors.is_empty() {
-        // statusline text will have the form:
-        // [/home/user/readonly.txt is readonly, ..., /readonly2.txt is readonly] add ! to overwrite
-        error_msg = format!("{:?} use ! to overwrite", readonly_errors).replace('"', "");
-    }
+    let error_msg = errors.join(" ");
+    // if !readonly_errors.is_empty() {
+    //     // statusline text will have the form:
+    //     // [/home/user/readonly.txt is readonly, ..., /readonly2.txt is readonly] add ! to overwrite
+    //     error_msg = format!("{:?} use ! to overwrite", readonly_errors).replace('"', "");
+    // }
 
     if !error_msg.is_empty() {
         bail!(error_msg);
diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs
index eb7ad2e49511..7602c9c79591 100644
--- a/helix-view/src/document.rs
+++ b/helix-view/src/document.rs
@@ -960,19 +960,18 @@ impl Document {
 
     #[cfg(unix)]
     // Detect if the file is readonly and change the readonly field if necessary (unix only)
-    pub fn detect_readonly(&mut self) -> bool {
+    pub fn detect_readonly(&mut self) {
         use rustix::fs::{access, Access};
         // Allows setting the flag for files the user cannot modify, like root files
         self.readonly = match &self.path {
             None => false,
             Some(p) => access(p, Access::WRITE_OK).is_err(),
         };
-        self.readonly
     }
 
     #[cfg(not(unix))]
     // Detect if the file is readonly and change the readonly field if necessary (non-unix os)
-    pub fn detect_readonly(&mut self) -> bool {
+    pub fn detect_readonly(&mut self) {
         // TODO Use the Windows' function `CreateFileW` to check if a file is readonly
         // Discussion: https://github.com/helix-editor/helix/pull/7740#issuecomment-1656806459
         // Vim implementation: https://github.com/vim/vim/blob/4c0089d696b8d1d5dc40568f25ea5738fa5bbffb/src/os_win32.c#L7665
@@ -984,7 +983,6 @@ impl Document {
                 Ok(metadata) => metadata.permissions().readonly(),
             },
         };
-        self.readonly
     }
 
     /// Reload the document from its path.

From 9bcde990d178155c0f04b9b48ee2f2a3e6471819 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Thu, 3 Aug 2023 20:17:20 -0400
Subject: [PATCH 24/29] removed dead code

---
 helix-term/src/commands/typed.rs | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index 7cf24fb69b98..a9ad64ebfdb7 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -676,19 +676,6 @@ pub fn write_all_impl(
                 }
                 return None;
             }
-            // if doc.detect_readonly() && !force {
-            //     if write_scratch {
-            //         readonly_errors.push(
-            //             format!(
-            //                 "{:?} is readonly",
-            //                 // Safety: doc.path() cannot be None from the if statement above
-            //                 doc.path().unwrap()
-            //             )
-            //             .replace('"', ""),
-            //         );
-            //     }
-            //     return None;
-            // }
 
             // Look for a view to apply the formatting change to. If the document
             // is in the current view, just use that. Otherwise, since we don't

From bbe6ccd44ef5292b92f363d25c6ef1b078a13018 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Thu, 3 Aug 2023 20:18:25 -0400
Subject: [PATCH 25/29] removed more dead code

---
 helix-term/src/commands/typed.rs | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index a9ad64ebfdb7..b805cf572a86 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -725,12 +725,6 @@ pub fn write_all_impl(
     }
 
     let error_msg = errors.join(" ");
-    // if !readonly_errors.is_empty() {
-    //     // statusline text will have the form:
-    //     // [/home/user/readonly.txt is readonly, ..., /readonly2.txt is readonly] add ! to overwrite
-    //     error_msg = format!("{:?} use ! to overwrite", readonly_errors).replace('"', "");
-    // }
-
     if !error_msg.is_empty() {
         bail!(error_msg);
     }

From 608844934f17a7093ce4e28c18be7565ed88f8de Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Thu, 3 Aug 2023 20:19:50 -0400
Subject: [PATCH 26/29] better description

---
 book/src/configuration.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/book/src/configuration.md b/book/src/configuration.md
index d24b9ed11df5..eb2cf473cffd 100644
--- a/book/src/configuration.md
+++ b/book/src/configuration.md
@@ -108,7 +108,7 @@ The following statusline elements can be configured:
 | `file-modification-indicator` | The indicator to show whether the file is modified (a `[+]` appears when there are unsaved changes) |
 | `file-encoding` | The encoding of the opened file if it differs from UTF-8 |
 | `file-line-ending` | The file line endings (CRLF or LF) |
-| `read-only-indicator` | The indicator to show whether a file is read only |
+| `read-only-indicator` | An indicator that shows `[readonly]` when a file cannot be written |
 | `total-line-numbers` | The total line numbers of the opened file |
 | `file-type` | The type of the opened file |
 | `diagnostics` | The number of warnings and/or errors |

From 1b55179066f8e8219e5f4c34cf2788f1baca6ce4 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Sat, 5 Aug 2023 08:16:38 -0400
Subject: [PATCH 27/29] fix lint

---
 helix-term/src/ui/statusline.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/helix-term/src/ui/statusline.rs b/helix-term/src/ui/statusline.rs
index c2f5636230c4..52dd49f9e212 100644
--- a/helix-term/src/ui/statusline.rs
+++ b/helix-term/src/ui/statusline.rs
@@ -451,7 +451,8 @@ where
         " [readonly] "
     } else {
         ""
-    }.to_string();
+    }
+    .to_string();
     write(context, title, None);
 }
 

From 3c9ba32971c80e6425fcc5c85259316592ef9f31 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Mon, 7 Aug 2023 20:44:54 -0400
Subject: [PATCH 28/29] revert to static str

---
 helix-term/src/commands/typed.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index b805cf572a86..8ff7d6d7bbf3 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -656,7 +656,7 @@ pub fn write_all_impl(
     force: bool,
     write_scratch: bool,
 ) -> anyhow::Result<()> {
-    let mut errors: Vec<String> = Vec::new();
+    let mut errors: Vec<&'static str> = Vec::new();
     let auto_format = cx.editor.config().auto_format;
     let jobs = &mut cx.jobs;
     let current_view = view!(cx.editor);
@@ -672,7 +672,7 @@ pub fn write_all_impl(
             }
             if doc.path().is_none() {
                 if write_scratch {
-                    errors.push("cannot write a buffer without a filename".to_string());
+                    errors.push("cannot write a buffer without a filename");
                 }
                 return None;
             }

From 04f9a579f3d51994a66c603fb4518c723b070836 Mon Sep 17 00:00:00 2001
From: Connor Tsui <connor.tsui20@gmail.com>
Date: Mon, 7 Aug 2023 20:50:45 -0400
Subject: [PATCH 29/29] revert whole function

---
 helix-term/src/commands/typed.rs | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs
index 8ff7d6d7bbf3..5bb9c6c41749 100644
--- a/helix-term/src/commands/typed.rs
+++ b/helix-term/src/commands/typed.rs
@@ -720,13 +720,8 @@ pub fn write_all_impl(
         cx.editor.save::<PathBuf>(id, None, force)?;
     }
 
-    if force {
-        return Ok(());
-    }
-
-    let error_msg = errors.join(" ");
-    if !error_msg.is_empty() {
-        bail!(error_msg);
+    if !errors.is_empty() && !force {
+        bail!("{:?}", errors);
     }
 
     Ok(())