-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update scala tree-sitter grammar #7147
chore: update scala tree-sitter grammar #7147
Conversation
Is there also any highlight query changes? It's usually not enough to just bump the grammar |
It's a little hard to tell looking at the diff (compare) but it looks like all of the changes are structural or to unnamed rules so we may not need to update the highlights queries. We could add the new locals queries though for better highlighting: https://github.com/tree-sitter/tree-sitter-scala/commits/e37d21701bd03d5bb27f5e2e8339ce6afc419784 |
What are local queries (sorry not a tree-sitter expert). |
Ah sorry, I mixed up the permalink. I think we should be able to use these out-of-the-box https://github.com/tree-sitter/tree-sitter-scala/blob/798ec789401de159e0c07ae170c8ae6dfbbfd94c/queries/scala/locals.scm copying them to runtime/queries/scala/locals.scm. (Also see https://tree-sitter.github.io/tree-sitter/syntax-highlighting#local-variables) |
Oooh, I see, thank you! |
* chore: update scala tree-sitter grammar * Add locals.scm for Scala
* chore: update scala tree-sitter grammar * Add locals.scm for Scala
* chore: update scala tree-sitter grammar * Add locals.scm for Scala
* chore: update scala tree-sitter grammar * Add locals.scm for Scala
Update to a new Scala tree-sitter grammar revision, because the current one lags behind by quite a bit:
https://github.com/tree-sitter/tree-sitter-scala/commits/master