Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Prisma tree-sitter for view support #5417

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Update Prisma tree-sitter for view support #5417

merged 1 commit into from
Jan 6, 2023

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Jan 5, 2023 •
edited
Loading

Updates the tree-sitter for view support.

view Foo {
  id Int @unique
}

Closes: #5385

@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jan 5, 2023
@archseer
Copy link
Member

archseer commented Jan 6, 2023

Should the view keyword be added to the highlights query?

@pimeys
Copy link
Contributor Author

pimeys commented Jan 6, 2023

Should the view keyword be added to the highlights query?

I'll take a look.

@pimeys
Copy link
Contributor Author

pimeys commented Jan 6, 2023

Should the view keyword be added to the highlights query?

Done, amended and force-pushed. See the screenshot from this build:

2023-01-06_09-01-1672995193

@pimeys
Copy link
Contributor Author

pimeys commented Jan 6, 2023

If somebody is interested on testing this, you need a build from this PR together with a development version of the prisma-language-server package, which you can either install from npm or from the nix flake.

@ivktac
Copy link
Contributor

ivktac commented Jan 6, 2023

looks like it needs to add (view_declaration (identifier) @type) to the queries to highlight also an identifier

@pimeys
Copy link
Contributor Author

pimeys commented Jan 6, 2023

Fixed that one too, another screenshot:

2023-01-06_11-01-1673002153

@the-mikedavis the-mikedavis merged commit 5627c60 into helix-editor:master Jan 6, 2023
@pimeys pimeys deleted the prisma/view-support branch January 6, 2023 13:34
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
Update Prisma tree-sitter for view support (helix-editor#5417)
1232d4e
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
Update Prisma tree-sitter for view support (helix-editor#5417)
a9160cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support views in Prisma schema language files
5 participants
@pimeys @archseer @ivktac @the-mikedavis @kirawi