Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically track pseudo-pending text #4077

Merged
merged 1 commit into from
Oct 3, 2022

Commits on Oct 2, 2022

  1. Automatically track pseudo-pending text

    This change automatically tracks pending text for for commands which use
    on-next-key callbacks. For example, `t` will await the next key event
    and "t" will be shown in the bottom right-hand corner to show that we're
    in a pending state.
    
    Previously, the text for these on-next-key commands needed to be
    hard-coded into the command definition which had some drawbacks:
    
    * It was easy to forget to write and clear the pending text.
    * If a command was remapped in a custom config, the pending text would
      still show the old key.
    
    With this change, pending text is automatically tracked based on the
    key events that lead to the command being executed. This works even
    when the command is remapped in config and when the on-next-key
    callback is nested under some key sequence (for example `mi`).
    the-mikedavis committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    1f613df View commit details
    Browse the repository at this point in the history