Replace shell_pipe_to with shell_pipe_popup #1988
Closed
+61
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would otherwise maybe keep the output-ignoring variant of shell_pipe, but I couldn't find a reasonable working key mapping. |
|
I think it'd be good to keep [keys.normal]
"|" = "shell_pipe_to" |
|
I agree, my bad, didn't think about that I can just keep it there. Fixed. |
The new shell_pipe_popup performs a similar function to shell_pipe_to but also allows the user to see the output in an automatically closing popup.
|
Actually, I'd personally find this feature more useful if it joined all selections with spaces or newlines before piping to a single shell command. The current implementation runs n commands for n selections and shows n results in a popup. |
|
I'd personally prefer the default keybinding and offer this as an alternative |
the-mikedavis
added
the
S-waiting-on-author
kirawi
added
A-helix-term
|
closing this one out as stale. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new shell_pipe_popup performs a similar function but also allows the user to see the output in an automatically closing popup.
I know this #1682 is similar, but I want selection piping and quick output feedback for running word counts.