Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict cursorline to editing area #2912

Open
ChrHorn opened this issue Jun 29, 2022 · 1 comment · May be fixed by #11948
Open

Restrict cursorline to editing area #2912

ChrHorn opened this issue Jun 29, 2022 · 1 comment · May be fixed by #11948
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@ChrHorn
Copy link
Contributor

ChrHorn commented Jun 29, 2022

The newly merged cursorline currently is drawn across the whole window, including the gutter. I think it would look better if the cursorline is only drawn in the editing area, that's how it's done in VSCode, Vim, etc. We also already can set the background (for the line numbers) with ui.linenr.selected, so it's a bit redundant.

@archseer
Copy link
Member

I think this is a s side-effect because the code was copied from the debugger, where we did want to highlight the whole line.

@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-helix-term Area: Helix term improvements labels Jun 29, 2022
@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors labels Jun 30, 2022
@dreck-sallow dreck-sallow linked a pull request Oct 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
4 participants