Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning when editing a readonly file #2627

Closed
Visne opened this issue May 31, 2022 · 1 comment
Closed

No warning when editing a readonly file #2627

Visne opened this issue May 31, 2022 · 1 comment
Labels
A-gui Area: Helix gui improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@Visne
Copy link

Visne commented May 31, 2022

When opening a file you are not allowed to edit, no indication is given that this is the case. Also, when you start editing, there is no warning either. And then if you do :wq, Helix closes without issues. This means that you can think you have edited a file, without ever realizing that the file is readonly and nothing has changed.

Vim on the other hand has [readonly] in the bottom bar when opening the file, gives a red colored warning when starting editing, and when :wq is tried an error is shown and the editor remains open.

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements labels May 31, 2022
@the-mikedavis
Copy link
Member

The :wq not failing: #1575

A read-only indicator in the status-line would be a nice addition I think 👍

@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors A-gui Area: Helix gui improvements and removed A-helix-term Area: Helix term improvements labels Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-gui Area: Helix gui improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants