Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impossible to build helix from tar.gz #1451

Closed
Pungolo opened this issue Jan 6, 2022 · 5 comments
Closed

impossible to build helix from tar.gz #1451

Pungolo opened this issue Jan 6, 2022 · 5 comments

Comments

@Pungolo
Copy link

Pungolo commented Jan 6, 2022

hello. if you use the source
https://github.com/helix-editor/helix/archive/refs/tags/v0.6.0.tar.gz
the build fails because the required submodules are not found with the files in the helix-syntax directory.

is it possible to upload a complete source archive?

@WindSoilder
Copy link
Contributor

WindSoilder commented Jan 6, 2022

For now it's impossible because github doesn't provide this feature: dear-github/dear-github#214

@o3bvv
Copy link

o3bvv commented Jan 6, 2022

The same is true for building from git repo: build.rs explicitly tries to build several languages which are not present in languages dir.

Commenting out tsx and ocaml-interface allows to finish the build successfully.

helix/helix-syntax/build.rs

Lines 203 to 206 in a8fd33a

build_dir("tree-sitter-typescript/tsx", "tsx");
build_dir("tree-sitter-typescript/typescript", "typescript");
build_dir("tree-sitter-ocaml/ocaml", "ocaml");
build_dir("tree-sitter-ocaml/interface", "ocaml-interface")

image
image

@kirawi
Copy link
Member

kirawi commented Jan 9, 2022

tsx is defined in https://github.com/tree-sitter/tree-sitter-typescript/tree/master/tsx
ocaml-interface is defined in https://github.com/tree-sitter/tree-sitter-ocaml/tree/master/interface

@sudormrfbin
Copy link
Member

I think this can be closed now since we don't use submodules now and have #1659 ?

@the-mikedavis
Copy link
Member

Yep with #1659, the submodules are gone and the cargo build is able to fetch and build tree-sitter grammars. #1875 was also just merged that will mean the next release will have a helix-VERSION-source.tar.xz which includes the source plus the grammar repositories already fetched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants