Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS connector update #5327

Merged
merged 1 commit into from
Dec 5, 2022
Merged

JMS connector update #5327

merged 1 commit into from
Dec 5, 2022

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Nov 4, 2022 •
edited
Loading

Fixes #4445, #5290

  • Add custom Weblogic JMS connector
  • Add NACK support to JMS/WLS/AQ connectors
  • Add connector attribute annotations to JMS/WLS connectors

Weblogic JMS connector

Custom Weblogic connector loads thin client jar with separate classloader, avoiding conflicts with non jakartified HK2.

mp:
  messaging:
    connector:
      helidon-weblogic-jms:
        # JMS factory configured in Weblogic
        jms-factory: jms/TestConnectionFactory
        # Path to the WLS Thin T3 client jar
        thin-jar: wlthint3client.jar
        url: t3s://localhost:7002
        producer.unit-of-order: kec1
    incoming:
      from-wls:
        connector: helidon-weblogic-jms
        # WebLogic CDI Syntax(CDI stands for Create Destination Identifier)
        destination: ./TestJMSModule!TestQueue
    outgoing:
      to-wls:
        connector: helidon-weblogic-jms
        destination: ./TestJMSModule!TestQueue

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 4, 2022
@barchetta barchetta added the 3.x Issues for 3.x version branch label Nov 4, 2022
@danielkec
4445 JMS connector
24bf4f4 
 - NACK support helidon-io#4445
 - WLS custom connector for thin client helidon-io#5290

Signed-off-by: Daniel Kec <[email protected]>

4445 JMS connector

Signed-off-by: Daniel Kec <[email protected]>

JMS nacking DLQ

Signed-off-by: Daniel Kec <[email protected]>

JMS nacking DLQ

Signed-off-by: Daniel Kec <[email protected]>

WLS Connector cleanup

Signed-off-by: Daniel Kec <[email protected]>

WLS Connector cleanup

Signed-off-by: Daniel Kec <[email protected]>

Test fix

Signed-off-by: Daniel Kec <[email protected]>

Example and WLS 14 support

Signed-off-by: Daniel Kec <[email protected]>

Example and WLS 14 support

Signed-off-by: Daniel Kec <[email protected]>

Revert kafka stuff

Signed-off-by: Daniel Kec <[email protected]>
@danielkec danielkec changed the title WIP: JMS connector update JMS connector update Nov 23, 2022
@danielkec danielkec linked an issue Nov 23, 2022 that may be closed by this pull request
WLS Thin T3 client doesn't work with Helidon 3 #5290
Closed
2 tasks
@danielkec danielkec mentioned this pull request Nov 23, 2022
Closed
16 tasks
tomas-langer
tomas-langer approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep track of WLS client and if there is a new version that would work without custom classloading, create an issue to update our implementation

This was referenced Dec 5, 2022
Merged
Closed
Closed
@danielkec danielkec merged commit e60c4d6 into helidon-io:helidon-3.x Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@spericas spericas Awaiting requested review from spericas

Assignees

@danielkec danielkec

Labels
3.x Issues for 3.x version branch OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WLS Thin T3 client doesn't work with Helidon 3 JMS connector - NACK support
3 participants
@danielkec @tomas-langer @barchetta