Fix invalid example in se/config/advanced-configuration.adoc (#4775) #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invalid Config.withSources on Config.builder (helidon-io#4775)
|
/oca-checked |
|
/trigger |
romain-grecourt
approved these changes
Sep 20, 2022
|
@romain-grecourt Can it be merged or we should wait for something? |
3 tasks
|
@Captain1653 The ports to 2.x and 4.x will need to be in separate PRs; a single PR can merge only into one branch. I've added check boxes for each Helidon release to the issue so we can track the separate PRs there. |
|
@tjquinno Thank you for your explanation. I was waiting for merging this PR, my mistake. I'll create backports soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4775
I can backport it into 2.x and 4.x after merging if necessary.
I've already signed OCA. It's an automation problem.